No other changes were made here.  Keeping everything in
src/test/test.c was a legacy of back when we had all our unit tests in
one big file.

Doing this now because I'm adding an ext_or_command test.

Remove a nedless strdup/free pair.

memwipe some stack-allocated stuff
Add DOCDOC comments for state machines
Use memdup_nulterm as appropriate
Check for NULs in useraddr
Add a macro so that <= AUTH_MAX has a meaning.

George Kadianakis authored 11 years ago and Nick Mathewson committed 11 years ago

- Don't leak if a transport proxy sends us a TRANSPORT command more
  than once.

- Don't use smartlist_string_isin() in geoip_get_transport_history().
  (pointed out by Nick)

- Use the 'join' argument of smartlist_join_strings() instead of
  trying to write the separator on our own.
  (pointed out by Nick)

- Document 'ext_or_transport' a bit better.
  (pointed out by Nick)

- Be a bit more consistent with the types of the values of 'transport_counts'.
  (pointed out by Nick)

George Kadianakis authored 11 years ago and Nick Mathewson committed 11 years ago

Pluggable transport names are now in alphabetical order like they
appear in the bridge-ip-transports string.

George Kadianakis authored 12 years ago and Nick Mathewson committed 11 years ago

* Change name of init_ext_or_auth_cookie_authentication().
* Add a small comment.

George Kadianakis authored 12 years ago and Nick Mathewson committed 11 years ago

Move the code from the connection_or module to ext_orport.

This commit only moves code: it shouldn't modify anything.

George Kadianakis authored 12 years ago and Nick Mathewson committed 11 years ago

* Add documentation.
* Free ext_or_auth_correct_client_hash.
* Use VPORT(ExtORPort) instead of V(ExtORPOrt).
  See dfe03d36 for details.

Does not implement TransportControlPort yet.

I added this so I could write a unit test for ServerTransportOptions,
but it incidentally exercises the succeed-on-defaults case of
options_validate too.

This removes some INLINE markers from functions that probably didn't
need them.