And more to the point, some GCCs will warn that you can't say it
before C90.

Bug not in any released version of Tor.

Robert Ransom authored 12 years ago and Nick Mathewson committed 12 years ago

Tor's and OpenSSL's current design guarantee that there are other leaks,
but this one is likely to be more easily exploitable, and is easy to fix.

Fix for 6530; fix on 0.2.2.6-alpha.

The values are only being checked, not modified.

Fixes 6480; fix on 0.2.0.1-alpha; based on pseudonymous patch.

Two of the do_*_test functions were actually prefixes of the third,
which suggests a trivial code elimination step

Fix for 6490.

Linus Nordberg authored 12 years ago and Nick Mathewson committed 12 years ago

Test for config option AuthDirPublishIPv6 == 1 rather than for running
as a bridge authority when deciding whether to care or not about IPv6
OR ports in descriptors.

Implements enhancement #6406.

Linus Nordberg authored 12 years ago and Linus Nordberg committed 12 years ago

Implements enhancement 5974.

Linus Nordberg authored 12 years ago and Linus Nordberg committed 12 years ago

To have only reachable ports in "a" lines.

Linus Nordberg authored 12 years ago and Linus Nordberg committed 12 years ago

We can end up in dirserv_orconn_tls_done() with a node missing
routerinfo in at least two cases -- command_process_certs_cell() and
connection_or_check_valid_tls_handshake() -- and probably more.

You can say "struct foo_t" as much as you want, but you'd better not
have "typedef struct foo_t foo_t" more than once.

Fix for bug 6416.  Bug not in any released version of Tor.

Roger Dingledine authored 12 years ago and Nick Mathewson committed 12 years ago

I only check on circuits, not streams, since bloating your stream
window past the initial circuit window can't help you much.

Also, I compare to CIRCWINDOW_START_MAX so we don't have surprising
races if we lower CIRCWINDOW_START for an experiment.

The SMARTLIST_FOREACH macro is more convenient than BEGIN/END when
you have a nice short loop body, but using it for long bodies makes
your preprocessor tell the compiler that all the code is on the same
line.  That causes grief, since compiler warnings and debugger lines
will all refer to that one line.

So, here's a new style rule: SMARTLIST_FOREACH blocks need to be
short.

Linus Nordberg authored 12 years ago and Nick Mathewson committed 12 years ago

Allow TestingTorNetwork when AlternateDirAuthority and
AlternateBridgeAuthority is set even if DirServer is not.