In validate_recommended_package_line, at this point in the function,
n_entries is always >= 1.  Coverity doesn't like us checking it for
0.

CID 1268063.

CID 1301373

Fixes CID 1306915, which noticed that the check was dead.

The function now unconditionally allocates a new extend_info_t.
This should convince coverity that we're not leaking memory.
(CID 1311875)

channel_unregister() removes channels from the current smartlist while
we're in a SMORTLIST_FOREACH loop. This only works by accident.

Sebastian Hahn authored 9 years ago and Nick Mathewson committed 9 years ago

This includes a small refactoring to use a new enum (workqueue_reply_t)
for the return values instead of just ints.

This avoids a conflict with a macro decl from libevent 1.x.

Fixes bug 16867; bug not in any released Tor.

We don't want to accept any work after one of our worker functions has
returned WQ_RPL_SHUTDOWN. This testcase currently fails, because we do
not actually stop any of the worker threads.