- Mar 28, 2023
-
-
meskio authored
-
- Mar 21, 2023
-
-
meskio authored
-
- Mar 20, 2023
- May 20, 2022
- Oct 01, 2021
-
-
Cecylia Bocovich authored
ORCONN events with the bridge names in their fingerprints were being ignored by bridgestrap.
-
- Aug 23, 2021
-
- Aug 10, 2021
-
-
Cecylia Bocovich authored
This fixes a bug that occurs in requests that have both cached and uncached bridge lines. In this case, we would serve the cached results but then pass the unmodified TestRequest to Tor with both cached and uncached bridges.
-
Cecylia Bocovich authored
-
- Jul 22, 2021
-
-
meskio authored
We were not using the mux to empty the CollecTor data. Related: #20
-
- Jul 13, 2021
-
-
meskio authored
Closes: #18
- Jul 06, 2021
-
-
meskio authored
Produce daily metrics for collector and expose them in https://[Bridgestrap URL]/collector. It produces metrics for each bridge tested and for the number of requests resolved by cached results. Bridgestrap stores the metrics on a file once per day. In case of bridgestrap restarts it will loose all the metrics that hasn't being stored as they are kept in memory. The implementation is heavily inspired on the snowflake broker metrics: https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/blob/master/broker/metrics.go Closes: #15
-
- Jan 07, 2021
-
-
Philipp Winter authored
-
Philipp Winter authored
Issue/12 See merge request !5
-
- Jan 04, 2021
-
-
Philipp Winter authored
So far, bridgestrap would only consume Tor's controller events from c.eventChan as long as the main execution flow was in TestBridgeLines. Outside of that function, controller events would keep on coming but not be consumed. That worked fine for a while because c.eventChan has a buffer of 100 events but occasionally it would result in the buffer filling up, which would cause a deadlock because bulb, our controller library, would block on sending bridgestrap its events. This patch fixes the issue by also consuming events outside of TestBridgeLines. The patch further adds a new Prometheus time series called pending_events, which captures the number of pending events. The time series will help us monitor if this patch got the job done.
-
- Jan 03, 2021
-
-
Philipp Winter authored
This should fix a race condition that we ran into in deployment: fatal error: concurrent map iteration and map write goroutine 98984 [running]: runtime.throw(0x95bb18, 0x26) /home/phw/sw/go/src/runtime/panic.go:1116 +0x72 fp=0xc0001735a8 sp=0xc000173578 pc=0x437e32 runtime.mapiternext(0xc000173650) /home/phw/sw/go/src/runtime/map.go:853 +0x554 fp=0xc000173628 sp=0xc0001735a8 pc=0x412534 main.(*TestCache).FracFunctional(0xc00016e960, 0xc00014a990) /home/phw/rcs/bridgestrap/cache.go:64 +0xbb fp=0xc0001736c0 sp=0xc000173628 pc=0x8610db main.(*TestCache).AddEntry(0xc00016e960, 0xc00031caa0, 0x98, 0x9dab00, 0xc00002e060, 0x13d5c8c, 0xed78148dc, 0x0) /home/phw/rcs/bridgestrap/cache.go:161 +0x17c fp=0xc000173730 sp=0xc0001736c0 pc=0x861c5c main.testBridgeLines(0xc00000f500, 0x1c)
-
- Dec 18, 2020
-
-
Philipp Winter authored
When bridgestrap read its cache from disk, it wouldn't only read the cache entries but also the cache timeout, overriding whatever we provided over the command line. In other words, if bridgestrap saved a cache whose timeout was set to 24h, and we later restart bridgestrap with a given cache timeout of 18h, it would use 24h because that's what it read from disk. This patch fixes this bug in two ways: 1) we no longer write the cache timeout to disk and 2) we set the cache timeout after reading the cached entries from disk.
-
Philipp Winter authored
This patch is a follow-up commit to tpo/anti-censorship/bridgestrap#10.
-
Philipp Winter authored
It's important that bridgestrap's cache timeout is less than or equal to rdsys's pluggable transport expiry time. If bridgestrap expires cache entries after 24 hours and rdsys wants to re-test bridges after 18 hours, then there's a worst case of a 6 hour window within which bridgestrap will refuse to re-test rdsys's bridges because they're still in the cache. Rdsys will keep bothering bridgestrap because it wants a more recent test result. This patch reduces bridgestrap's default cache timeout to 18 hours, which is the number of hours after which bridges should re-upload their descriptors to the bridge authority: https://gitweb.torproject.org/torspec.git/tree/dir-spec.txt?id=c2a584144330239d6aa032b0acfb8b5ba26719fb#n369
-
Philipp Winter authored
This patch 1) makes obfs4proxy log its output to file and 2) adds a log message that prints the error message (if any) after sending a "SIGNAL ACTIVE" tor tor.
-
- Dec 14, 2020
-
-
Philipp Winter authored
-
- Dec 11, 2020
-
-
Philipp Winter authored
By default, tor goes to sleep after 24 hours of no user activity. Bridgestrap's control port interaction does not count as user activity, which means that tor effectively stops working after 24 hours. To work around this, we're sending tor a SIGNAL ACTIVE, which wakes up tor in case it went to sleep. This is a cheap thing to do, so we might as well do it before each SETCONF. This patch fixes tpo/anti-censorship/bridgestrap#12.
-
- Dec 07, 2020
-
-
Philipp Winter authored
-
- Dec 03, 2020
-
-
Philipp Winter authored
Make metrics more idiomatic to Prometheus. Closes #10 See merge request tpo/anti-censorship/bridgestrap!4
-
- Dec 01, 2020
-
-
Philipp Winter authored
Our metrics aren't implemented in the way Prometheus recommends. This patch makes use of labels and renames our metrics to change that. For example, instead of having two metrics called cache_hits and cache_misses, we now have a single metric called cache_total and it accepts a "type" label that can take on the values "hit" or "miss". This patch fixes tpo/anti-censorship/bridgestrap#10.
-
- Nov 30, 2020
-
-
Philipp Winter authored
Our timeout is set to 60 by default, so the actual execution time is 60 + a few milliseconds. Adding +1 to the final bucket covers that case.
-
- Nov 26, 2020
-
-
Philipp Winter authored
-
- Nov 25, 2020
-
-
Philipp Winter authored
-
- Nov 23, 2020
-
-
Philipp Winter authored
Export Prometheus-based metrics Closes #4 See merge request !3
-
- Nov 21, 2020
-
-
Philipp Winter authored
-
Philipp Winter authored
The way Prometheus works is that a central instance scrapes metrics from various endpoints, bridgestrap being one of them. We expose a new HTTP handler for /metrics and let our Prometheus library do the rest. This patch fixes tpo/anti-censorship/bridgestrap#4
-
Philipp Winter authored
So far, bridgestrap would serialise requests by relying on a mutex's locking mechanism. That's dirty. This patch implements a channel-based dispatching mechanism that guarantees order (mutexes don't). In addition to that, we can now log the number of outstanding requests, which is good to know.
-
- Nov 20, 2020
-
-
Philipp Winter authored
-
Philipp Winter authored
Having tor log at 'info' level makes its log files grow significantly faster.
-
Philipp Winter authored
-
Philipp Winter authored
-