Skip to content
Snippets Groups Projects

Improve testing branch for Lox distributor/wasm interactions

Merged onyinyang requested to merge onyinyang/lox:testing-test into testing

Closes #62 (closed) and should provide the functionality required for #67 so that we can #77 (closed)

Adding the end points revealed a bug in the lox-library's blocking function (or possibly elsewhere) that I need to make an issue for an get to the bottom of.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • meskio
  • 25 25 .body(full("Allow POST"))
    26 26 .unwrap()),
    27 27 _ => match (req.method(), req.uri().path()) {
    28 (&Method::POST, "/advancedays") => Ok::<_, Infallible>({
    29 let bytes = req.into_body().collect().await.unwrap().to_bytes();
    30 cloned_context.advance_days_with_response_test(bytes)
    31 }),
    32 (&Method::POST, "/blockbridges") => Ok::<_, Infallible>({
    • I assume we don't want those endpoints in production. Should we enable them only when compiled for testing?

      I see you mention in #62 (comment 3123674) the idea of having a testing branch. Having an extra branch looks like extra work to maintain needing to rebase it on main lox. I think it will be nice if we could make this compilation optional or at least disabled on run time if no flag -test (or any better name) is given.

    • Agree. I have fixed this and the `lox-distributor` changes should be good to merge with the main branch in !274 (merged) but I'll keep the changes in the lox-wasm crate separate (here) to be merged with the testing branch since those changes will not be compatible with the distributor from the main branch. Once !274 (merged) is merged, I'll rebase on that with the wasm related changes

    • onyinyang changed this line in version 9 of the diff

      changed this line in version 9 of the diff

    • This is now done.

    • Please register or sign in to reply
  • meskio
  • Looks good.

    My main concern is where this code will live and if it will be enabled on compilation time or by a flag. The rest are just style detail comments.

  • meskio requested changes

    requested changes

  • onyinyang added 8 commits

    added 8 commits

    • 398c2c97 - Update Rust crate lox-zkp to v0.8.1
    • db115226 - Update Rust crate thiserror to v2
    • 2a9f5a25 - Add advance time endpoint to distributor
    • dc24d9d5 - Let client set date on server, use server date
    • 74267704 - Add bridge blocking endpoint
    • cef8bbea - Fix u64 to JSON string fingerprint truncation for test
    • f1f3e9f1 - Increase percent spares so migration works
    • 13aaa06b - Add test-branch feature to distributor

    Compare with previous version

  • onyinyang mentioned in merge request !274 (merged)

    mentioned in merge request !274 (merged)

  • Moved the lox-distributor related changes to !274 (merged) and will wait to rebase the wasm changes once that's merged.

  • onyinyang added 8 commits

    added 8 commits

    • ca30ff27 - Update lox-zkp version
    • ef14d93f - Add advance time endpoint to distributor test
    • c9018b4f - Add bridge blocking endpoint
    • 09626f88 - Fix u64 to JSON string fingerprint truncation for test
    • 17e24bc4 - Minor fmt changes
    • a2417fbb - Increase percent spares so migration works
    • 17fb9de0 - Use server date for wasm functions
    • 4020e654 - Update wasm and index.js to enable bridge blocking

    Compare with previous version

  • onyinyang requested review from @meskio

    requested review from @meskio

  • meskio approved this merge request

    approved this merge request

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading