Standalone proxy probetest Wiki inconsistency and implementation details
- Our Wiki states that:
We determine the NAT behaviour of clients by using the tricks in RFC 5780 ... For standalone proxies written in Go, we use the same method.
Which is not true since we switched to probetest 00f8f85f
Cecylia linked the issue for the change: #40013 (closed). I will update the Wiki.
- Right now we are logging the SDP offer used for probetest, which might be misleading because before looking into this in detail I always thought we were logging the SDP candidates used for WebRTC connection. Does this help the user in any way or is simplying logging the resultant NAT type enough? Some options to consider:
- keep the same logging, but made it extra clear that this is only used for probetest, not peer connection
- log SDP candidates for WebRTC. I think this would be helpful for debugging, but could produce much more logs
- log both
-
Update Wiki with reason to use probetest -
Research on whether we should respect proxy options in probetest -
Decide what to log
Edited by itchyonion