Bug 41679: Backport Android-specific security fixes from Firefox 111 to ESR 102.9-based Tor Browser (fenix portion)
- Mar 15, 2023
-
-
Mugurell authored
The new version will contain the support for allowing to style download dialogs.
-
Mugurell authored
-
Mugurell authored
This uses the same direction as the before patch - inflating a new View that can then serve as an anchor for the Snackbar. Here we could use directly the AC layout as it needed no special customization.
-
Mugurell authored
Tried to mimic the UX of a modal dialog while using Android Views. This meant including a scrim that would consume all touches and theming the navigation bar and status bar. Avoiding a dialog and a separate window will allow the snackbar to see the new "dialog" as a sibling in a CoordinatorLayout parent and so be able to position itself based on the new "dialog". This patch also added "start_download_dialog_layout" from A-C as it leads to simpler and less code needed to style the layout - colors / shapes with everything happening in XML versus calculating the values then setting them programatically.
-
Mugurell authored
Previously Android-Components - BrowserToolbarBehavior would be responsible for positioning the snackbar above the toolbar. With that responsibility removed we can handle in Fenix positioning the snackbar depending on the toolbar and many more cases - like positioning it depending on the download dialogs.
-