Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
F
fenix
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 51
    • Issues 51
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 3
    • Merge Requests 3
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • The Tor Project
  • Applications
  • fenix
  • Merge Requests
  • !47

Closed
Opened Oct 15, 2020 by Matthew Finkel@sysrqbMaintainer
  • Report abuse
Report abuse

Draft: Bug 40068: Tor Service closes when changing theme

  • Overview 4
  • Commits 2
  • Pipelines 2
  • Changes 2

Now we do not stop tor when the activity is destroyed because that may happen when the Activity is being recreated. Therefore, we track when the app is being recreated using a new isBeingRecreated flag. In the case where isBeingRecreated is true, we don't reset it as false because the Activity instance is (or should be) destroyed immediately after onDestroy returns and a new Activity instance is created. In the case where isBeingRecreated is false, we finish all Activities in this app (finishAffinity) and then we let the Application (FenixApplication) terminate itself.

I am sure there must be a cleaner way of accomplishing this, but this seems to work well enough.

Closes #40068 (closed)

Assignee
Assign to
Reviewer
Request review from
Tor Browser: 10.0
Milestone
Tor Browser: 10.0
Assign milestone
Time tracking
Reference: tpo/applications/fenix!47
Source branch: bug_40068_00