Bug 42089: Remove ability to submit site support requests

Merge Info

Related Issues

• tor-browser#42007 (closed)
• tor-browser#42089 (closed)

Backporting

Timeline

• Immediate: patchset needed as soon as possible
• Next Minor Stable Release: patchset that needs to be verified in nightly before backport
• Eventually: patchset that needs to be verified in alpha before backport
• No Backport (preferred): patchset for the next major stable

(Optional) Justification

• Emergency security update: patchset fixes CVEs, 0-days, etc
• Censorship event: patchset enables censorship circumvention
• Critical bug-fix: patchset fixes a bug in core-functionality
• Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
• Sponsor required: patchset required for sponsor
• Other: please explain

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Review

Request Reviewer

@dan @donuts

• Request review from an applications developer depending on modified system:
  • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
  • accessibility : henry
  • android : clairehurst, dan
  • build system : boklm
  • extensions : ma1
  • firefox internals (XUL/JS/XPCOM) : ma1
  • fonts : pierov
  • frontend (implementation) : henry
  • frontend (review) : donuts, richard
  • localization : henry, pierov
  • macos : clairehurst, dan
  • nightly builds : boklm
  • rebases/release-prep : dan, ma1, pierov, richard
  • security : ma1
  • signing : boklm, richard
  • updater : pierov
  • misc/other : pierov, richard

Change Description

(Left is tor browser, right is firefox nightly) For when a site is not supported, it should not have an onClick() event or display a '>'. Normally it would open a dialog allowing the user to submit a site support request. This feature should be entirely removed, with all supporting code removed as well.

How Tested

1. Connect to Tor
2. Go to settings -> Privacy and Security -> Cookie banner reduction -> Turn on "Reduce cookie banners"
3. Go to torproject.org (or any site really, I haven't found a site that actually supports cookie banner reduction yet)
4. Notice that "Cookie Banner Reduction" says "Site not currently supported" and cannot be tapped (which would normally prompt the user to submit a site support request) and does not have a '>' symbol next to it which would normally indicate that it can be tapped.