Bug_42115: Enhanced Tracking Protection can still be enabled

Merge Info

Related Issues

• tor-browser#42115 (closed)

Backporting

Timeline

• Immediate: patchset needed as soon as possible
• Next Minor Stable Release: patchset that needs to be verified in nightly before backport
• Eventually: patchset that needs to be verified in alpha before backport
• No Backport (preferred): patchset for the next major stable

(Optional) Justification

• Emergency security update: patchset fixes CVEs, 0-days, etc
• Censorship event: patchset enables censorship circumvention
• Critical bug-fix: patchset fixes a bug in core-functionality
• Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
• Sponsor required: patchset required for sponsor
• Other: please explain

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Review

@dan

Request Reviewer

• Request review from an applications developer depending on modified system:
  • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
  • accessibility : henry
  • android : clairehurst, dan
  • build system : boklm
  • extensions : ma1
  • firefox internals (XUL/JS/XPCOM) : ma1
  • fonts : pierov
  • frontend (implementation) : henry
  • frontend (review) : donuts, richard
  • localization : henry, pierov
  • macos : clairehurst, dan
  • nightly builds : boklm
  • rebases/release-prep : dan, ma1, pierov, richard
  • security : ma1
  • signing : boklm, richard
  • updater : pierov
  • misc/other : pierov, richard

Change Description

How Tested

1. Go to youtube.com (I think it just has to be a site with cookies that were disabled, speedtest.net also works)
2. Tap on the Lock icon next to the URL
3. Notice there is no blank section that just says "Details", and therefore no way to get into protection settings to enable ETP

added Android label

requested review from @dan

assigned to @clairehurst

added 1 commit

• dc087eea - Bug_42115: Enhanced Tracking Protection can still be enabled

Compare with previous version

added 4 commits

• dc087eea...296e0aaa - 3 commits from branch tpo/applications:firefox-android-115.2.1-13.0-1
• d6a3207c - Bug_42115: Enhanced Tracking Protection can still be enabled

Compare with previous version

I think we've learned commenting out the xml may be over kill and make glean sad.

otherwise looks good. This should probably be a fix up for one of our logical commits, like "Disable stuff" or "ui/ux" prolly?

resolved all threads

Is this good to merge then?

added 1 commit

• a9a10fef - fixup! Disable features and functionality

Compare with previous version

marked this merge request as draft from clairehurst/firefox-android@a9a10fef

resolved all threads

approved this merge request

added 2 commits

• f2fc794e - 1 commit from branch tpo/applications:firefox-android-115.2.1-13.0-1
• 533daef0 - fixup! Disable features and functionality

Compare with previous version

marked this merge request as ready

merged