Skip to content

Bug 41188: Implement Android-native Connection Assist UI

clairehurst requested to merge clairehurst/firefox-android:bug_41188 into firefox-android-115.2.1-13.5-1

Merge Info

Related Issues

Backporting

Timeline

  • Immediate: patchset needed as soon as possible
  • Next Minor Stable Release: patchset that needs to be verified in nightly before backport
  • Eventually: patchset that needs to be verified in alpha before backport
  • No Backport (preferred): patchset for the next major stable

(Optional) Justification

  • Emergency security update: patchset fixes CVEs, 0-days, etc
  • Censorship event: patchset enables censorship circumvention
  • Critical bug-fix: patchset fixes a bug in core-functionality
  • Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
  • Sponsor required: patchset required for sponsor 96
  • Other: please explain

Issue Tracking

Review

@dan @pierov

Request Reviewer

  • Request review from an applications developer depending on modified system:
    • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
    • accessibility : henry
    • android : clairehurst, dan
    • build system : boklm
    • extensions : ma1
    • firefox internals (XUL/JS/XPCOM) : ma1
    • fonts : pierov
    • frontend (implementation) : henry
    • frontend (review) : donuts, richard
    • localization : henry, pierov
    • macos : clairehurst, dan
    • nightly builds : boklm
    • rebases/release-prep : dan, ma1, pierov, richard
    • security : ma1
    • signing : boklm, richard
    • updater : pierov
    • misc/other : pierov, richard

Change Description

This is a major reworking of the connection screen. It has a whole new UI and includes an architecture refactor by implementing MVVM and StateFlow and largely scrapping the old setup (both are still active based on a setting)

How Tested

To test all that is currently implemented: Launch app Go to settings -> Tor Network -> Enable beta connection features -> tap on Enable beta connection features -> select Native Android UI Navigate back to connection screen Examine the new UI Try connecting, canceling connecting, interrupting connecting by going to settings

Things not yet implemented: Auto connect, bridge support, error handling

Edited by clairehurst

Merge request reports