Skip to content

Bug_41188: Improve Connection Assist

clairehurst requested to merge clairehurst/firefox-android:bug_41188v3 into firefox-android-115.2.1-13.5-1

Merge Info

Related Issues

Backporting

Timeline

  • Immediate: patchset needed as soon as possible
  • Next Minor Stable Release: patchset that needs to be verified in nightly before backport
  • Eventually: patchset that needs to be verified in alpha before backport
  • No Backport (preferred): patchset for the next major stable

(Optional) Justification

  • Emergency security update: patchset fixes CVEs, 0-days, etc
  • Censorship event: patchset enables censorship circumvention
  • Critical bug-fix: patchset fixes a bug in core-functionality
  • Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
  • Sponsor required: patchset required for sponsor
  • Other: please explain

Issue Tracking

Review

@dan @pierov

Request Reviewer

  • Request review from an applications developer depending on modified system:
    • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
    • accessibility : henry
    • android : clairehurst, dan
    • build system : boklm
    • extensions : ma1
    • firefox internals (XUL/JS/XPCOM) : ma1
    • fonts : pierov
    • frontend (implementation) : henry
    • frontend (review) : donuts, richard
    • localization : henry, pierov
    • macos : clairehurst, dan
    • nightly builds : boklm
    • rebases/release-prep : dan, ma1, pierov, richard
    • security : ma1
    • signing : boklm, richard
    • updater : pierov
    • misc/other : pierov, richard

Change Description

This is a good place to push up what I have before working more on error screens and connectivity wizard stuff related to tor-browser#41188

How Tested

Poke around with the Native Android UI connection assist, particularly the "base" screen, the bootstrapping screen, quickstart, the splash screen, and any other screen you can get to. Error screens partially implemented, but getting to them is blocked by tor-browser#42251 and additional error messages (like the TorConnect Internet test to determine if we can reach the internet or not). Also blocked by “additional wiring” to get the list of countries from moat for the "We can't connect to Tor directly" screen

Edited by clairehurst

Merge request reports