Bug 42576: Backport Bug 1885171: use the private keyboard for prompts on Android

Merge Info

Related Issues

• tor-browser#42576 (closed)
• tor-browser-build#xxxxx

Backporting

Timeline

• Immediate: patchset needed as soon as possible
• Next Minor Stable Release: patchset that needs to be verified in nightly before backport
• Eventually: patchset that needs to be verified in alpha before backport
• No Backport (preferred): patchset for the next major stable

@richard/@ma1: what do you think about backporting?

This isn't on Firefox stable yet, but I think it's a nice addition at least for 13.5.

(Optional) Justification

• Emergency security update: patchset fixes CVEs, 0-days, etc
• Censorship event: patchset enables censorship circumvention
• Critical bug-fix: patchset fixes a bug in core-functionality
• Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
• Sponsor required: patchset required for sponsor
• Other: disk-leak fix, but on windows.prompt, which probably aren't a feature that used these days

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Review

Request Reviewer

• Request review from an applications developer depending on modified system:
  • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
  • accessibility : henry
  • android : clairehurst, dan
  • build system : boklm
  • extensions : ma1
  • firefox internals (XUL/JS/XPCOM) : ma1
  • fonts : pierov
  • frontend (implementation) : henry
  • frontend (review) : donuts, richard
  • localization : henry, pierov
  • macos : clairehurst, dan
  • nightly builds : boklm
  • rebases/release-prep : dan, ma1, pierov, richard
  • security : ma1
  • signing : boklm, richard
  • updater : pierov
  • misc/other : pierov, richard

Change Description

Chery-pick upstream Bug 1885171.

This fix makes window.prompt open a private keyboard (if the keyboard - such as GBoard - supports it).

It's an upstream fix. It doesn't apply completely cleanly, but the changes to make it fit are minor.

How Tested

1. checked w3school's example for window.prompt
2. compared the diff of my MR with upstream's diff