Skip to content
Snippets Groups Projects
  1. May 06, 2024
  2. May 03, 2024
  3. May 02, 2024
  4. Apr 16, 2024
  5. May 01, 2024
  6. May 02, 2024
  7. May 01, 2024
  8. Apr 30, 2024
  9. Apr 29, 2024
  10. Apr 25, 2024
  11. Apr 24, 2024
  12. Feb 27, 2024
  13. Apr 27, 2024
    • Daniel Holbert's avatar
      Bug 1890514: Null-check 'view' before using it, in... · d06e1650
      Daniel Holbert authored
      Bug 1890514: Null-check 'view' before using it, in nsTreeBodyFrame::RemoveImageCacheEntry.  a=dmeehan
      
      If it's null, we'll now just take the existing something-failed early-return codepath.
      
      The 'view' local variable here is really just an alias for mView, and we have
      null-checks for mView elsewhere, so it's conceivable that it could be null when
      we get to this point. (And we have a low but nonzero level of crash volume for
      folks hitting a null-deref on this line, which seems to confirm that it is
      occasionally null here.)
      
      I'm not including a test since I'm not sure how to trigger the conditions
      required to crash in this way.  But the change is pretty trivial and clearly
      a step in the direction of safety-against-crashing.
      
      Original Revision: https://phabricator.services.mozilla.com/D207817
      
      Differential Revision: https://phabricator.services.mozilla.com/D208379
      d06e1650
  14. Apr 26, 2024
  15. Apr 25, 2024
Loading