Marco Simonelli authored 2 years ago and Pier Angelo Vendrame committed 6 months ago

- properly define NOMINMAX for just MSVC builds

Differential Revision: https://phabricator.services.mozilla.com/D211090

Differential Revision: https://phabricator.services.mozilla.com/D211719

Also remove the rustc < 1.68 hack, as we no longer support that version.

Differential Revision: https://phabricator.services.mozilla.com/D211091

MOZ_CHECK_ALLOCATOR was defining HAVE_VALLOC and HAVE_ALIGNED_MALLOC
which are unused, so get rid of these checks.

Differential Revision: https://phabricator.services.mozilla.com/D210278

Differential Revision: https://phabricator.services.mozilla.com/D207752

Differential Revision: https://phabricator.services.mozilla.com/D209734

Bug 1897470 - Replace _WIN32_MSVC checks with something more accurate. r=firefox-build-system-reviewers,ahochheiden

The _WIN32_MSVC checks assume the host and target compilers are the
same, which is not the case when cross-compiling for Android.

Differential Revision: https://phabricator.services.mozilla.com/D210976

Differential Revision: https://phabricator.services.mozilla.com/D203781

Get read of -pthreads because (according to gcc info page) it's only
there on solaris and as an alias to -pthread.

-D_REENTRANT is always defined by gcc and clang when -pthreads is on.
-D_THREAD_SAFE is only defined on AIX by clang

so get rid of the related actions.

libpthreads is an AIX thing, I assume we can remove it too.

c/cxx flags are always added to the linker flags, so don't do any
linker-related addition.

Differential Revision: https://phabricator.services.mozilla.com/D203687

Actually remove the check for demangle, no supported target need that
check.

Also make library dependencies explicit instead of relying on "$LIBS".

Differential Revision: https://phabricator.services.mozilla.com/D203637

Differential Revision: https://phabricator.services.mozilla.com/D209733

To be clear: the define is used, but everything that uses it defines it locally.

Differential Revision: https://phabricator.services.mozilla.com/D210277

The header has been in mingw since 2010, and is in the Windows SDK since
well before the version we require.

Differential Revision: https://phabricator.services.mozilla.com/D209377

The -ldl flag was previously set globally, it's now set for the libs
that use it.

Also rationalize the difference between HAVE_DLOPEN and HAVE_DLFCN_H.

Differential Revision: https://phabricator.services.mozilla.com/D203594

Backed out 3 changesets (bug 1883720, bug 1883719, bug 1883615) for causing multiple failures. CLOSED TREE

Backed out changeset 495b9e84ba9d (bug 1883720)
Backed out changeset 5a89cbc54dd2 (bug 1883615)
Backed out changeset 9d075e352b0e (bug 1883719)

Actually remove the check for demangle, no supported target need that
check.

Also make library dependencies explicit instead of relying on "$LIBS".

Differential Revision: https://phabricator.services.mozilla.com/D203637

The -ldl flag was previously set globally, it's now set for the libs
that use it.

Also rationalize the difference between HAVE_DLOPEN and HAVE_DLFCN_H.

Differential Revision: https://phabricator.services.mozilla.com/D203594

Bug 1894716 - Change Android build to use -O2 optimization level r=firefox-build-system-reviewers,glandium

Optimize android at "-O2" (speed) instead of "-Oz" (reduced code size) because the performance improvements on benchmarks and pageload outweigh the expected increased in binary size.

Differential Revision: https://phabricator.services.mozilla.com/D209967

Optimize android at "-O2" (speed) instead of "-Oz" (reduced code size) because the performance improvements on benchmarks and pageload outweigh the expected increased in binary size.

Original Revision: https://phabricator.services.mozilla.com/D209967

Differential Revision: https://phabricator.services.mozilla.com/D211031

Differential Revision: https://phabricator.services.mozilla.com/D207729

Backed out changeset 4309f75eaa90 (bug 1883615) for causing build bustages related to check_symbol_in_libs. CLOSED TREE

The -ldl flag was previously set globally, it's now set for the libs
that use it.

Also rationalize the difference between HAVE_DLOPEN and HAVE_DLFCN_H.

Differential Revision: https://phabricator.services.mozilla.com/D203594

This check is used to set $EXEXT, which is unused, but it also sets
$ac_exeext which is used internally for various tests, including
AC_TRY_LINK.

Interestingly, setting $ac_exeext to a non empty value bypasses the only
portability issue with MinGW that automatically adds a `.exe` suffix if no
extension is given. So Always set `.out` as extension, as it's only used
internally.

Differential Revision: https://phabricator.services.mozilla.com/D207001

This is defines HAVE_DIRENT_H which is never actually referenced.

Differential Revision: https://phabricator.services.mozilla.com/D203881

mode_t comes from POSIX.1-2008
pid_t comes from POSIX.1-2008
off_t comes from POSIX.1-2008

Differential Revision: https://phabricator.services.mozilla.com/D205569

It seems to be actually relevant for mingw. Re-enabling it restores the
build to its normal state.

Differential Revision: https://phabricator.services.mozilla.com/D204828

It seems to be actually relevant for mingw. Re-enabling it restores the
build to its normal state.

Differential Revision: https://phabricator.services.mozilla.com/D204828

AC_C_CONST is officially useless, see https://www.gnu.org/software/autoconf/manual/autoconf-2.60/html_node/C-Compiler.html
AC_TYPE_SIZE_T is probably as useless, size_t is a standard type in C99 (from stddef.h)
AC_EXEEXT sets EXEEXT which is never used (and the internal ac_cv_exeext which is not used either)
MISSING_X is never referenced

Differential Revision: https://phabricator.services.mozilla.com/D203732

Differential Revision: https://phabricator.services.mozilla.com/D203014

Differential Revision: https://phabricator.services.mozilla.com/D202421

Differential Revision: https://phabricator.services.mozilla.com/D201942

Differential Revision: https://phabricator.services.mozilla.com/D201937

Differential Revision: https://phabricator.services.mozilla.com/D201724

Differential Revision: https://phabricator.services.mozilla.com/D202188

Bug 679359 - Autodetect WIN32_REDIST_DIR. r=firefox-build-system-reviewers,sergesanspaille,nalexander

Differential Revision: https://phabricator.services.mozilla.com/D202191

Bug 1880930 - Remove irrelevant comment from old-configure.in. r=firefox-build-system-reviewers,sergesanspaille

The comment was added in bug 407459, but the code it was relevant to was
moved without the comment in bug 1257448. At the same time, while the
code that came with the comment was moved and is still relevant, the
comment itself refers to code that was removed in bug 1364358.

Differential Revision: https://phabricator.services.mozilla.com/D202189

Bug 1524461 introduced a typo, using __VA_ARGS instead of __VA_ARGS__. A
previous attempt to fix that led to bug 1684265 and the fix has been in
limbo since then. Bug 1876415 however recently changed things so that
mac builds may not use CLOCK_MONOTONIC for TimeStamp, which would avoid
bug 1684265 after fixing the configure test.

Since the first attempt, though, the availability() hack ceased to work.
At the same time, macOS < 10.12 is not supported anymore, so all
supported versions of macOS do have CLOCK_MONOTONIC, so we just remove
the availability() hack altogether.

Differential Revision: https://phabricator.services.mozilla.com/D202187

This flag is only meaningful for gcc, take that into account.

Differential Revision: https://phabricator.services.mozilla.com/D201703

Provide the minimal support from moz.configure to do so.

The only observable change of this patch is to permute -fPIC and
-Wa,--noexecstack in ASFLAGS.

Differential Revision: https://phabricator.services.mozilla.com/D201349