- Feb 01, 2023
-
-
Paul Adenot authored
Bug 646323 - Rewrite mfbt/Casting.h assertion in modern style, and teach it to deal with floating point values. r=kinetik This now uses `if constexpr (...)` which is a lot more readable, and still compiles to almost no assembly instructions, as expected. Floating point casting assert when casting an integer that's too large to be represented exactly as a floating point (e.g. UINT64_MAX to double, since double have less than 64 bytes of mantissa), or when casting a double that's too large to be represented in a float. Differential Revision: https://phabricator.services.mozilla.com/D167955
-
moz-wptsync-bot authored
Bug 1813043 - [wpt-sync] Update web-platform-tests to 19120235de9eac1ff8c6b5392e621d907b51890b, a=testonly MANUAL PUSH: wpt sync bot wpt-head: 19120235de9eac1ff8c6b5392e621d907b51890b wpt-type: landing
-
Anne van Kesteren authored
Automatic update from web-platform-tests HTML: <meta http-equiv name> Test for https://github.com/whatwg/html/issues/8776. -- wpt-commits: 0e390d78148b9044460bff3f9b784a492764b9a4 wpt-pr: 38190
-
moz-wptsync-bot authored
wpt-pr: 38204 wpt-type: metadata
-
Xiaocheng Hu authored
Automatic update from web-platform-tests Convert animation-timeline property value to tree-scoped Following the plan in crrev.com/c/4167268, this patch converts the animation-timeline property to use tree-scoped-populated CSS values instead of ScopedCSSValue. There's a minor behavior change that the support of <string> values in the property has been removed. This is because: - The spec doesn't allow <string> values [1] - Allowing <string> values will complicate the implementation, as it requires populating TreeScope into a CSSStringValue, which doesn't make much sense Note: animation-timeline is currently an experimental feature, so we don't need any Blink intents to modify its behavior. [1] https://drafts.csswg.org/css-animations-2/#propdef-animation-timeline Bug: 1395026 Change-Id: I8a44e8d2759a49368cbe864d8c3285aa0a79dca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4196352 Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1097818} -- wpt-commits: 5ef3eda5c7ca71a2eadc01d9854893c33317ca0e wpt-pr: 38204
-
moz-wptsync-bot authored
wpt-pr: 37895 wpt-type: metadata
-
Jon Jensen authored
Automatic update from web-platform-tests Add FormData constructor submitter tests For https://github.com/whatwg/xhr/pull/366. -- wpt-commits: 0986c763928822dd6b62ee7223d8a54827f357c7 wpt-pr: 37895
-
Tim Nguyen authored
Automatic update from web-platform-tests Fix 2 invalid subtests in hypot-pow-sqrt-invalid.html (#38210) -- wpt-commits: 68df0e81258d983e1b5dbe7d339533fd2189edb0 wpt-pr: 38210
-
moz-wptsync-bot authored
wpt-pr: 38092 wpt-type: metadata
-
Aaron Krajeski authored
Automatic update from web-platform-tests Set epislon to 1 for integer colors rgb() and rgba() legacy color formats output their colors in integers. This CL allows for colorValuesAlmostEqual to supply two different epsilons, one for new color formats (which include decimals) and the legacy formats that don't. Bug: 1399566 Change-Id: If68ddc7e6fc499f443fecef9f8b89a0048eb8927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4185117 Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/main@{#1097610} -- wpt-commits: beefff0568744b7e93c51ffd22fb72eb261d50cb wpt-pr: 38092
-
moz-wptsync-bot authored
wpt-pr: 38159 wpt-type: metadata
-
Alison Maher authored
Bug 1812219 [wpt PR 38159] - [FlexNG] MinBlockSizeShouldEncompassIntrinsicSize for flex rows, a=testonly Automatic update from web-platform-tests [FlexNG] MinBlockSizeShouldEncompassIntrinsicSize for flex rows Update the MinBlockSizeShouldEncompassIntrinsicSize() calculation for flex row items to check if the container has an auto block-size in addition to whether or not the cross-size of the item would be the container size. Otherwise, we would fail to correctly expand due to fragmentation in some cases. See CL:3600998 for where the original logic was added. Bug: 1409030 Change-Id: I45b5455f16c84e0d409ebbfa3bf1b0994aff2feb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4193452 Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1097496} -- wpt-commits: c1061a66dc57bd054d681630ede9aea1fa38b348 wpt-pr: 38159
-
moz-wptsync-bot authored
wpt-pr: 38167 wpt-type: metadata
-
Johann Hofmann authored
Bug 1812328 [wpt PR 38167] - Add test for storage-access permission exposure via the Permissions API, a=testonly Automatic update from web-platform-tests Add test for storage-access permission exposure via the Permissions API This adds a new test that confirms that the storage-access permission is accessible through the permissions.query and observable as well. It also makes our message passing in these tests a little more robust by adding a simple timestamp to the messages to avoid crossing streams. This is needed for this test because it creates a condition where we need to wait for two different messages at the same time. Bug: 1401266 Change-Id: Iafa5d83cb580e7ea9c84cccd7210699fa5fc35d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4193792 Commit-Queue: Johann Hofmann <johannhof@chromium.org> Reviewed-by:
Chris Fredrickson <cfredric@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Auto-Submit: Johann Hofmann <johannhof@chromium.org> Quick-Run: Johann Hofmann <johannhof@chromium.org> Cr-Commit-Position: refs/heads/main@{#1097457} -- wpt-commits: 1f2389b4336242f4d822fe8435bbc6eeb083df93 wpt-pr: 38167
-
Mehdi Kazemi authored
Bug 1812053 [wpt PR 38142] - Consecutive touch scrolling should generate only one scrollend event, a=testonly Automatic update from web-platform-tests Consecutive touch scrolling should generate only one scrollend event Touch scroll, pause, touch scroll again and we should receive only one scrollend event. Add waitForCompositorReady() which runs an opacity animation before doing the actual test, so that we are sure the compositor thread is ready. If we don't wait for the compositor, we'll have flaky tests. Before we start each test we reset the scrolling state, and one way of making sure that the state have been applied is to wait for the compositor commit. In this case we are using a 1ms opacity animation that forces the commit (because it runs on the compositor) and after that we are sure everything is in its initial state. Bug: 1400447 Change-Id: I3ca62a01e947229e4698f934f0f2d441e656a424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4191397 Commit-Queue: Mehdi Kazemi <mehdika@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1097449} -- wpt-commits: 5f6fcbca38f393b23b401600662a4abd8365bf3b wpt-pr: 38142
-
moz-wptsync-bot authored
wpt-pr: 38148 wpt-type: metadata
-
Ian Kilpatrick authored
Bug 1812137 [wpt PR 38148] - [baseline-source] Set baseline-source to auto when vertical-align set., a=testonly Automatic update from web-platform-tests [baseline-source] Set baseline-source to auto when vertical-align set. The csswg would like the vertical-align property to become a shorthand in the future (mapping to baseline-source alignment-offset baseline-shift). In order to mitigate the future compat risk of shipping this shorthand set baseline-source to auto when vertical-align is set. Bug: 1399711 Change-Id: Ia713b07b5d6c98dd0b8fbce7f1c9d3ca602708f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4189506 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1097120} -- wpt-commits: d12505b978385137c4e5e2c00634d52be782804e wpt-pr: 38148
-
Tony Herre authored
Automatic update from web-platform-tests Add frameType to RTCEncodedVideoFrameMetadata Add a field specifying if a frame is a key or delta frame to the RTC encoded frame metadata. Without this, encodedFrame.setMetadata(encodedFrame.getMetadata()) would reset the frame type in the header to "kEmptyFrame", causing it to be dropped before being sent on a PeerConnection, making it hard to test setMetadata(). Guarded by the same feature as the rest of this additional metadata: RTCEncodedVideoFrameAdditionalMetadata. Bug: webrtc:14709 Change-Id: Id93622dc7488f04900debff450689113fe757840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4181178 Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Tony Herre <toprice@chromium.org> Cr-Commit-Position: refs/heads/main@{#1097421} -- wpt-commits: 672d747e92e68a55697fbeb69f8f9c14e2ebdf29 wpt-pr: 38164
-
moz-wptsync-bot authored
wpt-pr: 38173 wpt-type: metadata
-
François Beaufort authored
Automatic update from web-platform-tests Clean up Image Capture code | part 3 This has no functional changes: - s/setOptions/setPhotoOptions Bug: 1408091 Change-Id: I048ce449ece3f7e903ef0c86291dfa0da235a97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4194295 Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/main@{#1097415} -- wpt-commits: 4e17a33fbdb24da477eba3ceed1a896fb4ed130f wpt-pr: 38173
-
Tim Nguyen authored
Bug 1812536 [wpt PR 38191] - Fix units in signs-abs-computed.html and hypot-pow-sqrt-computed.html, a=testonly Automatic update from web-platform-tests Fix units in signs-abs-computed.html and hypot-pow-sqrt-computed.html (#38191) By default test_math_used will use lengths as units and that will test against `margin-left`, which fails for integers/numbers. -- wpt-commits: 9b62fac316e44f7b83aaf93643543b0287c0e18b wpt-pr: 38191
-
Simon Pieters authored
Automatic update from web-platform-tests XML: comment and PI in doctype internal subset Comments and PIs in the doctype should not be represented in the DOM. -- wpt-commits: 8e07a869b464e339fe0b28735b036458a30ebbd5 wpt-pr: 38136
-
Alexey Shvayka authored
Bug 1812579 [wpt PR 38197] - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=250936, a=testonly Automatic update from web-platform-tests WebKit export of https://bugs.webkit.org/show_bug.cgi?id=250936 (#38197) -- wpt-commits: f33bae95de4de17a509f61be931e76f3502607b4 wpt-pr: 38197
-
moz-wptsync-bot authored
wpt-pr: 38168 wpt-type: metadata
-
Kevin Ellis authored
Bug 1812332 [wpt PR 38168] - [view-timeline]: Move range(Start|End) from timing to animation option., a=testonly Automatic update from web-platform-tests [view-timeline]: Move range(Start|End) from timing to animation option. Bug: 1383162 Change-Id: I89580aa49e5ea15d24fd5a539686ed2c707b4e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192769 Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1097376} -- wpt-commits: fb26286f6722021a5d980f386b0d22c95dcf0596 wpt-pr: 38168
-
Fredrik Hernqvist authored
Automatic update from web-platform-tests Fix WebRTC web tests Bug: chromium:1409922 webrtc:14653 Change-Id: I335ae8cb7fec3782265fdf9522672646cbd89677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4195744 Commit-Queue: Fredrik Hernqvist <fhernqvist@google.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/main@{#1097361} -- wpt-commits: 61989c55ff44c4267504d7f6eca1b9b744d2b29e wpt-pr: 38198
-
moz-wptsync-bot authored
wpt-pr: 38171 wpt-type: metadata
-
Raphael Kubo da Costa authored
Bug 1812348 [wpt PR 38171] - wake lock: Move tests in web_tests/wake-lock to either wpt_internal or external/wpt., a=testonly Automatic update from web-platform-tests wake lock: Move tests in web_tests/wake-lock to either wpt_internal or external/wpt. We had Wake Lock-related tests in 3 different directories: external/wpt/screen-wake-lock/, wake-lock/, and wpt_internal/system-wake-lock. Get rid of the wake-lock/ directory by moving the tests in it to the other two directories: * wakelock-document-hidden.https.html: Move it to WPT. It was not there because it depended on setMainWindowHidden(). WPT has since added support for controlling page visibility via test_driver.minimize_window() and test_driver.set_window_rect(), so we can use them via window_state_context(). While here, merge some bits and pieces from WPT's wakelock-document-hidden-manual.https.html and remove the manual test, both tests were essentially testing the same thing. * wakelockpermissiondescriptor.https.html: Move to wpt_internal/system-wake-lock/, as it was just checking if a system wake lock has a proper permission descriptor. While at it, turn it into a .js test to make it shorter. Change-Id: I4a524c1fcafbb44c4a063ede81e616a60115a0db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4194594 Auto-Submit: Raphael Kubo Da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/main@{#1097304} -- wpt-commits: 7423999e37650128670a940dca4ad35ac4f71b67 wpt-pr: 38171
-
moz-wptsync-bot authored
wpt-pr: 38150 wpt-type: metadata
-
Rimas Misevičius authored
Automatic update from web-platform-tests URL: fix setters tests These tests were introduced in the https://github.com/web-platform-tests/wpt/pull/38032 . U+000D is a newline character and must be removed before further processing. Closes #38182. Co-authored-by:
Anne van Kesteren <annevk@annevk.nl> -- wpt-commits: f1ade799d04b72b0ff75c13e988744c2cd873741 wpt-pr: 38150
-
moz-wptsync-bot authored
wpt-pr: 38189 wpt-type: metadata
-
Tim Nguyen authored
Automatic update from web-platform-tests Split out style query tests from at-container-parsing.html (#38189) -- wpt-commits: f6c69a2401c6fb3bfe948f5c5fc2557a4f347142 wpt-pr: 38189
-
Jean-Philippe Gravel authored
Automatic update from web-platform-tests Correctly detect duplicate WPT canvas tests. The code was treating any tests defined with a different implementation for HTML and Offscreen canvas as duplicate. This produced a lot of false positive error messages. This noise prevented us from seeing that some tests were in fact truly defined twice. Bug: 1409873 Change-Id: Ib9c7694f7719be20fc4ee0ce00e71609e50cab68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4193438 Reviewed-by:
Yi Xu <yiyix@chromium.org> Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1097246} -- wpt-commits: 4082c2a4d354fb9213023a1aad06011605ad976b wpt-pr: 38188
-
moz-wptsync-bot authored
wpt-pr: 38186 wpt-type: metadata
-
Tim Nguyen authored
Bug 1812502 [wpt PR 38186] - Add tests for fit-content block-size on constrained out-of-flow elements, a=testonly Automatic update from web-platform-tests Add tests for fit-content block-size on constrained out-of-flow elements (#38186) See https://bugzilla.mozilla.org/show_bug.cgi?id=1772305 -- wpt-commits: a2f60307b51c0ff713db0069f8a406f7f6662d8f wpt-pr: 38186
-
Jean-Philippe Gravel authored
Automatic update from web-platform-tests Break the canvas WPT tool scripts into smaller functions. All of the code was in a single huge function, making it hard to navigate, modify and maintain. Change-Id: Idf1f29f2dc528192657bdd8c05cbd674e856de61 Bug: 1409873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4193469 Reviewed-by:
Yi Xu <yiyix@chromium.org> Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1097227} -- wpt-commits: a8ebaf5b59ef56d254495969a2161c7a5817a569 wpt-pr: 38187
-
Jean-Philippe Gravel authored
Bug 1812499 [wpt PR 38184] - Simplify handling of name-to-subdir mapping in canvas WPT tool scripts., a=testonly Automatic update from web-platform-tests Simplify handling of name-to-subdir mapping in canvas WPT tool scripts. Decoupling the name-to-subdir mapping from the "-manual" suffix handling lifts the requirement of caring about `name` vs. `mapped_name` everywhere, which will allow for nice refactorization in the follow up CL. Change-Id: Ib74683b40bf2d190b39711d3a4716d2e100d2ebc Bug: 1409873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4190580 Reviewed-by:
Yi Xu <yiyix@chromium.org> Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1097214} -- wpt-commits: dc22505fd7b397578e66ed3088166b5c4c66b952 wpt-pr: 38184
-
Nidhi Jaju authored
Automatic update from web-platform-tests Revert "Propagate tree scope to keyframes" This reverts commit 50c25ed46796e593de8358b69af78127fde1c8e9. Reason for revert: Suspect for blink_wpt_tests and blink_web_tests failing on WebKit Linux Leak builder i.e. https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Linux%20Leak/47313/overview Original change's description: > Propagate tree scope to keyframes > > As a follow up patch of crrev.com/c/4167268, this patch resolves > tree-scopes references in keyframes by propagating the tree scope > to the keyframes, and use that to create tree-scope-populated > CSSValues for interpolations. > > Change-Id: I4cb21b0fbfdc9d8072ad77705ae3516c52e41df2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4167011 > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1097028} Change-Id: I23493cd16574750061a5c1a8764e8a8a09ddc448 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4196234 Auto-Submit: Nidhi Jaju <nidhijaju@chromium.org> Owners-Override: Nidhi Jaju <nidhijaju@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Nidhi Jaju <nidhijaju@chromium.org> Cr-Commit-Position: refs/heads/main@{#1097181} -- wpt-commits: 872549666d0710bd410d2b421e81ff93f8b19364 wpt-pr: 38185
-
Jean-Philippe Gravel authored
Bug 1812491 [wpt PR 38183] - Remove dead code in web_tests/external/wpt/html/canvas/tools scripts., a=testonly Automatic update from web-platform-tests Remove dead code in web_tests/external/wpt/html/canvas/tools scripts. Change-Id: Iac87114c802f5f204e0225977a099d2a50fc7843 Bug: 1409873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192288 Reviewed-by:
Yi Xu <yiyix@chromium.org> Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1097175} -- wpt-commits: ec2b326d62619d2007d621435283bfc205bba220 wpt-pr: 38183
-
Weizhong Xia authored
Automatic update from web-platform-tests Handle '/' in url query string or fragment (#38156) * Handle '/' in url query string or fragment Previously we used rpartition to get the test name for test id. This will break if there is '/' in query string or fragment. Follow how this is done previously to correctly handle such case. -- wpt-commits: 89142292ab8c7f3564d978a76fdabc66626c421e wpt-pr: 38156
-