Differential Revision: https://phabricator.services.mozilla.com/D108490

Bug 1698543 - Rework handling of interaction between incremental barriers and rope flattening r=sfink

Currently we have a special path for performing barriers during rope flattening to take account of the fact that this overwrites the cell header word of ropes temporarily, making these cells untraceable.

The problem is that a rope can already be in the barrier buffer before flattening starts and so we need to check for this when processing the buffer.

The patch reworks use of temporary GC data to set one of the cell header flags when in use. This means we can check for it when processing the barrier buffer. It removes the special case function for barriers, which makes it slightly less efficient as we will now buffer all these ropes before skipping them later on. Hopefully that is not too deterimental to performance.

Differential Revision: https://phabricator.services.mozilla.com/D108664

Bug 1699036 - Fix build error on (symbol 'profiler_is_locked_on_current_thread()' is multiply-defined) on platforms with MOZ_GECKO_PROFILER not defined, r=gerald. DONTBUILD

Differential Revision: https://phabricator.services.mozilla.com/D108744

Bug 1696397: Move SpinEventLoopUntilOrShutdown to -Quit and move the current shutdown state logic from nsThreadManager to AppShutdown; r=kmag,xpcom-reviewers

The SpinEventLoopUntilOrShutdown is interrupted in the main process only at stage "xpcom-shutdown", which is too late. In a content process instead we interrupt it early enough, at "content-child-will-shutdown".

This patch removes the current observer logic in nsThreadManager in favor of a current shutdown phase state machinery in AppShutdown and renames SpinEventLoopUntilOrShutdown to SpinEventLoopUntilOrQuit. It also ensures that SpinEventLoopUntilOrQuit breaks early (at "quit-application" in the main process).

For a further possible cleanup around shutdown state in child and parent process please refer to bug 1697745.

We have no automated test for this edge case, but we have diagnostic telemetry that will tell us if it helps.

Differential Revision: https://phabricator.services.mozilla.com/D107619

Differential Revision: https://phabricator.services.mozilla.com/D108559

This test can oom on some underprovisioned 64-bit platforms like those in our CI,
so allow that as an outcome.

Differential Revision: https://phabricator.services.mozilla.com/D108740

Differential Revision: https://phabricator.services.mozilla.com/D107616

Bug 1697115 - Rationalize QuotaManager::DecreaseUsageForClient arguments; r=dom-storage-reviewers,sg

Note that the method DecreaseUsageForOrigin has been renamed to
DecreaseUsageForClient.

Differential Revision: https://phabricator.services.mozilla.com/D107615

Bug 1697115 - Rationalize QuotaManager::NoteOriginDirectoryCreated arguments and return type; r=dom-storage-reviewers,sg

Differential Revision: https://phabricator.services.mozilla.com/D107614

Differential Revision: https://phabricator.services.mozilla.com/D107612

Differential Revision: https://phabricator.services.mozilla.com/D107611

Bug 1697115 - Use FullOriginMetadata instead of OriginMetadata in QuotaManager::LoadQuota::LoadQuotaFromCache; r=dom-storage-reviewers,sg

Differential Revision: https://phabricator.services.mozilla.com/D107610

Bug 1697115 - Rename mTimestamp to mLastAccessTime in FullOriginMetadata; r=dom-storage-reviewers,sg

Differential Revision: https://phabricator.services.mozilla.com/D107609

Differential Revision: https://phabricator.services.mozilla.com/D108380

MozPromiseHolder stores only a single pointer and so there is no advantage to
having an allocation and additional pointer indirection.

Differential Revision: https://phabricator.services.mozilla.com/D108379

There is a change in behavior that the SourceListener::Stop() is now run off a
queued event, but timing is not urgent.

Differential Revision: https://phabricator.services.mozilla.com/D108378

Denied() is called only from Observe(), which is main thread only.

The comment "Should happen *after* error runs for consistency, but may not
matter" was obsolete as of
https://hg.mozilla.org/mozilla-central/rev/46c936ce7efed56027d7770690f94ee31f415d7a#l3.634

Differential Revision: https://phabricator.services.mozilla.com/D108377

MozPromise can be rejected from any thread.

"Do after the above runs, as it checks active window list" was obsolete as of
https://hg.mozilla.org/mozilla-central/rev/99426a6a77bf8ddfb334ed052eb18e2a9bc48122#l3.223

Differential Revision: https://phabricator.services.mozilla.com/D108376

Differential Revision: https://phabricator.services.mozilla.com/D108375

Differential Revision: https://phabricator.services.mozilla.com/D108368

Differential Revision: https://phabricator.services.mozilla.com/D108367

Bug 1697970 - Disable test_arraybufferinputstream_large.html on linux asan for permafailing. r=jstutte,necko-reviewers,valentin

Differential Revision: https://phabricator.services.mozilla.com/D108220

Bug 1691402 - [marionette] Don't try to destroy a non-existent session. r=marionette-reviewers,jdescottes,jgraham

If there is no active WebDriver session the code
related to deleting a session, and resetting other
state should not be run again.

This could actually happen when the
"Marionette:Quit" command is called, which itself
destroys the session, and the follwing socket
connection drop tries to run it again.

Differential Revision: https://phabricator.services.mozilla.com/D108169

Bug 1691402 - [marionette] Move current browsing context members to WebDriver session. r=marionette-reviewers,jdescottes,jgraham

Differential Revision: https://phabricator.services.mozilla.com/D108168

Bug 1691402 - [marionette] Add session module for WebDriver session. r=marionette-reviewers,jdescottes,jgraham

This patch creates a new module for the WebDriver session
specific implementation. It no longer requires session data
like capabilities to be directly bound to the GeckoDriver class.

Differential Revision: https://phabricator.services.mozilla.com/D107552

Differential Revision: https://phabricator.services.mozilla.com/D104746

This patch doesn't change behavior; GetCrossDocParentFrameInProcess() is just a
wrapper for GetCrossDocParentFrame(), which is what we were calling before.

The "InProcess" version of this API (which we're migrating to in this patch) is
used to annotate GetCrossDocParentFrame() callsites that have been vetted as
being OK with the fact that this API returns null at the boundary of a
cross-origin iframe, if fission is enabled.

In this patch, the one call that I'm migrating is inside of
IsFrameDescendantOfAny(), which is a helper-function called by
TextOverflow::PruneDisplayListContents(), which is a function that we use to
traverse a display list and hide content that's been hidden via
"text-overflow:ellipsis" or "-webkit-line-clamp".

We're OK to migrate this call to the "InProcess"-flavored API, because it's
just looking back up the frame tree from the display items that we can reach in
our traversal, which are trivially all part of the same process.

Differential Revision: https://phabricator.services.mozilla.com/D108710

Bug 1697991 - Enable Dark Mode support in the crash reporter client, and fix a case of black-on-black text. r=mac-reviewers,bradwerth

Differential Revision: https://phabricator.services.mozilla.com/D108151

Depends on D108345

Differential Revision: https://phabricator.services.mozilla.com/D108346

Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's __attribute__((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.

Depends on D108344

Differential Revision: https://phabricator.services.mozilla.com/D108345

Bug 1698706 - Always add PIC flags to C{,XX}FLAGS. r=firefox-build-system-reviewers,andi,sheehan,mhentges

The build always uses them anyways, but configure tests don't, and some
of them fail as a consequence in some cases (example: when UBsan is
enabled, all AC_LANG_CPLUSPLUS + AC_CHECK_FUNCS tests fail). We also had
similar problems in the past, such as bug 1513605.

By adding the PIC flags to CFLAGS and CXXFLAGS, we ensure old-configure
tests use the flags as well.

While here, we also remove DSO_CFLAGS, which was always empty, and we
stop passing -fPIC to wasm compiles, because it has no effect there.

Differential Revision: https://phabricator.services.mozilla.com/D108560

Bug 1697950 - Partial support for mach bootstrap on arm64 mac. r=firefox-build-system-reviewers,sheehan,mhentges

This is enough to make the instructions on the Google doc unnecessary.

Differential Revision: https://phabricator.services.mozilla.com/D108132

Bug 1698546. Don't allow double tap to zoom on mac when context menus are open in the same situations that we don't allow pinch zooming. r=mstange

Differential Revision: https://phabricator.services.mozilla.com/D108724

Bug 1698706 - Always add PIC flags to C{,XX}FLAGS. r=firefox-build-system-reviewers,andi,sheehan,mhentges

The build always uses them anyways, but configure tests don't, and some
of them fail as a consequence in some cases (example: when UBsan is
enabled, all AC_LANG_CPLUSPLUS + AC_CHECK_FUNCS tests fail). We also had
similar problems in the past, such as bug 1513605.

By adding the PIC flags to CFLAGS and CXXFLAGS, we ensure old-configure
tests use the flags as well.

While here, we also remove DSO_CFLAGS, which was always empty, and we
stop passing -fPIC to wasm compiles, because it has no effect there.

Differential Revision: https://phabricator.services.mozilla.com/D108560

Differential Revision: https://phabricator.services.mozilla.com/D107985

Differential Revision: https://phabricator.services.mozilla.com/D108389

Bug 1698719 - Remove aSkipFrames argument to both FramePointerStackWalk and MozStackWalkThread. r=gsvelto,gerald

In the case of FramePointerStackwalk, the caller gives a pointer to the
top-most frame to walk from. There isn't really a reason to give a
number of frames to skip, as the right frame pointer could be given in
the first place if that was really necessary. And in practice, it's
hasn't been used so far.

In the case of MozStackWalkThread, the caller presumably doesn't know
what the thread the stack is being walked for is doing, and it would be
a guesswork to pass a valid number of frames to skip. In practice, it's
also not used.

The aSkipFrames is already a footgun on MozStackWalk (and we're going to
change that in bug 1515229), we don't need to keep a footgun on these
other stack walking methods.

Differential Revision: https://phabricator.services.mozilla.com/D108563