Bug 305: Disable setting default browser on Windows

Merge Info

Related Issues

• #305 (closed)

Backporting

Timeline

• Immediate: patchset needed as soon as possible
• Next Minor Stable Release: patchset that needs to be verified in nightly before backport
• Eventually: patchset that needs to be verified in alpha before backport
• No Backport (preferred): patchset for the next major stable

(Optional) Justification

• Emergency security update: patchset fixes CVEs, 0-days, etc
• Critical bug-fix: patchset fixes a bug in core-functionality
• Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
• Sponsor required: patchset required for sponsor
• Localization: typos and other localization changes that should be also in the release branch
• Other: please explain

Merging

• Merge to mullvad-browser - !fixups to mullvad-browser-specific commits, new features, security backports
• Merge to base-browser -!fixups to base-browser-specific commits, new features to be shared with tor-browser
  • NOTE: if your changeset includes patches to both base-browser and mullvad-browser please clearly label in the change description which commits should be cherry-picked to base-browser after merging

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Review

Request Reviewer

• Request review from an applications developer depending on modified system:
  • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
  • accessibility : henry
  • android : clairehurst, dan
  • build system : boklm
  • extensions : ma1
  • firefox internals (XUL/JS/XPCOM) : jwilde, ma1
  • fonts : pierov
  • frontend (implementation) : henry
  • frontend (review) : donuts, richard
  • localization : henry, pierov
  • macOS : clairehurst, dan
  • nightly builds : boklm
  • rebases/release-prep : dan, ma1, pierov, richard
  • security : jwilde, ma1
  • signing : boklm, richard
  • updater : pierov
  • windows : jwilde, richard
  • misc/other : pierov, richard

Change Description

How Tested

Default Browser status and toggle should not be shown in about:preferences under General -> Startup. After closing and reopening the browser the Default Browser Setting query modal should not appear on startup. The browser.shell.checkDefaultBrowser, browser.shell.defaultBrowserCheckCount,browser.shell.setDefaultBrowserUserChoice, browser.shell.skipDefaultBrowserCheckOnFirstRun, browser.shell.didSkipDefaultBrowserCheckOnFirstRun, browser.shell.setDefaultPDFHandler, and browser.shell.shouldCheckDefaultBrowser prefs should be unchanged. (The defaults on a new profile and what they were set to previously on a pre-existing profile)

assigned to @jwilde

Pardon the noise, I seem to have 202 commits too many ^^;

requested review from @richard

added 185 commits

• 949bead6...dbf278c5 - 184 commits from branch tpo/applications:mullvad-browser-115.11.0esr-13.5-1
• 7a8c1520 - Bug 305: Disable setting default browser on Windows

Compare with previous version

added 203 commits

• 7a8c1520...ba54aca2 - 193 earlier commits
• 50b007b3 - MB 163: prevent uBlock Origin from being uninstalled/disabled
• ed4c5d53 - MB 188: Customize Gitlab Issue and Merge templates
• 8b215505 - MB 213: Customize the search engines list
• c9cd5087 - MB 214: Enable cross-tab identity leak protection in "quiet" mode
• 8cd3357e - MB 234: Disable OS spoofing in HTTP User-Agent.
• 85ff74f3 - MB 80: Enable Mullvad Browser as a default browser
• 03266584 - MB 290: Add default bookmarks in alpha channel for testing
• ee1d1495 - fixup! Firefox preference overrides.
• d82b4689 - Bug 1828259 - Close XUL popup when entering/exiting fullscreen; r=smaug
• dace2d0a - Bug 305: Disable setting default browser on Windows

Compare with previous version

marked this merge request as draft from jwilde/mullvad-browser@309081e6

changed target branch from mullvad-browser-115.11.0esr-13.5-1 to mullvad-browser-115.12.0esr-13.5-1

changed the description

marked this merge request as ready

lgtm, cc @pierov

Merging so we can verify in nightly tomorrow.

approved this merge request

merged

lgtm as well.

Nit: for Mullvad Browser we use the MB prefix instead of Bug, but we can reword at the next rebase.

Nit: for Mullvad Browser we use the MB prefix instead of Bug, but we can reword at the next rebase.

Other nit: there should be an empty line between the commit subject and the rest of the commit message.