MB 223: Use the localized brand files
requested to merge pierov/mullvad-browser:223-branding-localization into mullvad-browser-115.1.0esr-13.0-1
Merge Info
Related Issues
Backporting
Timeline
-
Immediate: patchset needed as soon as possible -
Next Minor Stable Release: patchset that needs to be verified in nightly before backport -
Eventually: patchset that needs to be verified in alpha before backport -
No Backport (preferred): patchset for the next major stable
(Optional) Justification
-
Emergency security update: patchset fixes CVEs, 0-days, etc -
Critical bug-fix: patchset fixes a bug in core-functionality -
Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc -
Sponsor required: patchset required for sponsor -
Other: please explain
Merging
-
Merge to mullvad-browser
-!fixups
tomullvad-browser
-specific commits, new features, security backports -
Merge to base-browser
-!fixups
tobase-browser
-specific commits, new features to be shared withtor-browser
-
NOTE: if your changeset includes patches to both
base-browser
andmullvad-browser
please clearly label in the change description which commits should be cherry-picked tobase-browser
after merging
-
NOTE: if your changeset includes patches to both
Issue Tracking
-
Link resolved issues with appropriate Release Prep issue for changelog generation
Review
Request Reviewer
-
Request review from an applications developer depending on modified system: -
NOTE: if the MR modifies multiple areas, please
/cc
all the relevant reviewers (since gitlab only allows 1 reviewer) - accessibility : henry
- android : dan
- build system : boklm
- extensions : ma1
- firefox internals (XUL/JS/XPCOM) : ma1
- fonts : pierov
- frontend (implementation) : henry
- frontend (review) : donuts, richard
- localization : henry, pierov
- nightly builds : boklm
- rebases/release-prep : dan_b, ma1, pierov, richard
- security : ma1
- signing : boklm, richard
- updater : pierov
- misc/other : pierov, richard
-
NOTE: if the MR modifies multiple areas, please
Change Description
At the moment, we aren't actually using the translated brand.ftl
.
With this commit, we start using them.
Also, this commit deletes brand.dtd
, that isn't used anymore.
Currently marked as draft because we need to add also brand.properties
, or the builds will fail.
Linux x86_64 test build (with the en-US brand.properties
): https://tb-build-05.torproject.org/~pierov/mullvadbrowser/nightly/tbb-nightly.2023.08.11/mullvad-browser-linux64-tbb-nightly.2023.08.11_ALL.tar.xz.
Edited by Pier Angelo Vendrame