Skip to content
Snippets Groups Projects
Closed Remove PT process options on Android
  • View options
  • Remove PT process options on Android

  • View options
  • Closed Issue created by Pier Angelo Vendrame

    From #40740 (comment 2938743):

    If the configuration from the bridge line is being passed in, then there's no need to set any command-line options. It should be just like the desktop version, running snowflake-client with no command-line options (cf. !540 (closed)).

    How it works is, some options can be set either on the command line or as SOCKS args. If both are present, the SOCKS args take precedence.

    SOCKS args are generally preferred to command-line arguments because they are more flexible. They apply per SOCKS connection, not globally, so you can, for example, have two bridge lines with different SOCKS args using the same instance of the pluggable transport executable.

    So it sounds like 12.5.3 is fine, but in the future you could also remove the command-line options from the Android version.

    And also, on IRC:

    PieroV | On other platforms we don't pass arguments in the ClientTransportPlugin
    PieroV | Should we stop doing it also on Android?
    PieroV | I think we use the same bridge lines as desktop
    cohosh | oh yeah we can remove all that then
    PieroV | But I'd need to check where they are injected first
    cohosh | okay, that makes sense
    cohosh | it' doesn't hurt to leave them fwiw

    I think our bridge lines are the same as desktop.

    At the moment, the nightly builds fail, because when I updated the patch for parameters I broke it, even though I cherry-picked it.

    So, we could do it already.

    Linked items ... 0

  • Activity

    • All activity
    • Comments only
    • History only
    • Newest first
    • Oldest first
    Loading Loading Loading Loading Loading Loading Loading Loading Loading Loading