Wrong copyright year makes build non-reproducible
14.5a2-build1 wasn't reproducible because var/copyright_year was wrong on Firefox (we missed a space before the commit hash).
Therefore, Tor Browser Alpha.app/Contents/Info.plist is wrong on macOS (and it affects both the dmg and the mar), and the copyright string in the exes is wrong:
i686 diff
diffoscope ma1/tor-browser-windows-i686-portable-14.5a2.exe ~/Tor/tor-browser-build/torbrowser/alpha/unsigned/14.5a2/tor-browser-windows-i686-portable-14.5a2.exe
--- ma1/tor-browser-windows-i686-portable-14.5a2.exe
+++ /home/piero/Tor/tor-browser-build/torbrowser/alpha/unsigned/14.5a2/tor-browser-windows-i686-portable-14.5a2.exe
@@ -7,15 +7,15 @@
00000060: 7420 6265 2072 756e 2069 6e20 444f 5320 t be run in DOS
00000070: 6d6f 6465 2e24 0000 5045 0000 4c01 0500 mode.$..PE..L...
00000080: 8043 6d38 0000 0000 0000 0000 e000 0301 .Cm8............
00000090: 0b01 0e00 0084 0000 00e4 0000 0000 0000 ................
000000a0: 173c 0000 0010 0000 0000 0000 0000 4000 .<............@.
000000b0: 0010 0000 0002 0000 0600 0000 0600 0000 ................
000000c0: 0600 0000 0000 0000 00d0 0600 0004 0000 ................
-000000d0: ee27 9606 0200 4085 0000 1000 0010 0000 .'....@.........
+000000d0: e6bc 9506 0200 4085 0000 1000 0010 0000 ......@.........
000000e0: 0000 1000 0010 0000 0000 0000 1000 0000 ................
000000f0: 0000 0000 0000 0000 005c 0100 a000 0000 .........\......
00000100: 0090 0500 203f 0100 0000 0000 0000 0000 .... ?..........
00000110: 0000 0000 0000 0000 0000 0000 0000 0000 ................
00000120: 0000 0000 0000 0000 0000 0000 0000 0000 ................
00000130: 0000 0000 0000 0000 0000 0000 0000 0000 ................
00000140: 0000 0000 0000 0000 0000 0000 0000 0000 ................
@@ -10543,15 +10543,15 @@
000292e0: 6e00 7300 7400 6100 6c00 6c00 6500 7200 n.s.t.a.l.l.e.r.
000292f0: 0000 0000 2e00 0700 0100 4600 6900 6c00 ..........F.i.l.
00029300: 6500 5600 6500 7200 7300 6900 6f00 6e00 e.V.e.r.s.i.o.n.
00029310: 0000 0000 3100 3400 2e00 3500 6100 3200 ....1.4...5.a.2.
00029320: 0000 0000 5200 1700 0100 4c00 6500 6700 ....R.....L.e.g.
00029330: 6100 6c00 4300 6f00 7000 7900 7200 6900 a.l.C.o.p.y.r.i.
00029340: 6700 6800 7400 0000 a900 2000 3200 3000 g.h.t..... .2.0.
-00029350: 3200 3500 2000 5400 6800 6500 2000 5400 2.5. .T.h.e. .T.
+00029350: 3200 3400 2000 5400 6800 6500 2000 5400 2.4. .T.h.e. .T.
00029360: 6f00 7200 2000 5000 7200 6f00 6a00 6500 o.r. .P.r.o.j.e.
00029370: 6300 7400 0000 0000 4400 1200 0100 5000 c.t.....D.....P.
00029380: 7200 6f00 6400 7500 6300 7400 4e00 6100 r.o.d.u.c.t.N.a.
00029390: 6d00 6500 0000 0000 5400 6f00 7200 2000 m.e.....T.o.r. .
000293a0: 4200 7200 6f00 7700 7300 6500 7200 2000 B.r.o.w.s.e.r. .
000293b0: 4100 6c00 7000 6800 6100 0000 3200 0700 A.l.p.h.a...2...
000293c0: 0100 5000 7200 6f00 6400 7500 6300 7400 ..P.r.o.d.u.c.t.
@@ -4194297,8 +4194297,8 @@
03ffff80: 3d42 8854 ac91 5422 9182 8fe2 2ec9 b04d =B.T..T".......M
03ffff90: bd7d 6db2 ab61 9709 1a94 09c2 4b00 139c .}m..a......K...
03ffffa0: 0484 741f 1719 43f6 1d1c f82d 6446 919d ..t...C....-dF..
03ffffb0: 0d35 a1af 665e cf43 4d27 4831 2147 5708 .5..f^.CM'H1!GW.
03ffffc0: 24d4 37a4 ccb2 1f4e 9a8f c076 e0e2 a017 $.7....N...v....
03ffffd0: 003a 73d7 d29d 32a6 5301 8df5 264c e74b .:s...2.S...&L.K
03ffffe0: 1e34 5100 e986 9523 aa34 d73b 428d 1b94 .4Q....#.4.;B...
-[ Too much input for diff (SHA256: 12be3603a8b64686a57a1caf87ef1ec54fb854a393e9d0b95ea391050d07f99a) ]
+[ Too much input for diff (SHA256: 41a8fdccf5278dc51426bd456bf2696bacfc7f9daea2683cb348fc358b4e069c) ]The diff in x86_64 is more involved, but hopefully the year is the problem, and the diff is a false-positive on diffoscope.
x86_64 diff
diffoscope ma1/tor-browser-windows-x86_64-portable-14.5a2.exe ~/Tor/tor-browser-build/torbrowser/alpha/unsigned/14.5a2/tor-browser-windows-x86_64-portable-14.5a2.exe
--- ma1/tor-browser-windows-x86_64-portable-14.5a2.exe
+++ /home/piero/Tor/tor-browser-build/torbrowser/alpha/unsigned/14.5a2/tor-browser-windows-x86_64-portable-14.5a2.exe
├── objdump
│ @@ -25,15 +25,15 @@
│ MajorImageVersion 6
│ MinorImageVersion 0
│ MajorSubsystemVersion 6
│ MinorSubsystemVersion 0
│ Win32Version 00000000
│ SizeOfImage 0006f000
│ SizeOfHeaders 00000400
│ -CheckSum 0693996f
│ +CheckSum 06937ed8
│ Subsystem 00000002 (Windows GUI)
│ DllCharacteristics 00008560
│ HIGH_ENTROPY_VA
│ DYNAMIC_BASE
│ NX_COMPAT
│ NO_SEH
│ TERMINAL_SERVICE_AWARE
│ @@ -60925,15 +60925,17 @@
│ 14006e93c: jb 0x14006e93e
│ 14006e93e: imul $0x680067,(%rax),%eax
│ 14006e944: je 0x14006e946
│ 14006e946: add %al,(%rax)
│ 14006e948: test $0x32002000,%eax
│ 14006e94d: add %dh,(%rax)
│ 14006e94f: add %dh,(%rdx)
│ - 14006e951: add %dh,0x54002000(%rip) # 0x194070957
│ + 14006e951: add %dh,(%rax,%rax,1)
│ + 14006e954: and %al,(%rax)
│ + 14006e956: push %rsp
│ 14006e957: add %ch,0x0(%rax)
│ 14006e95a: add %ah,%gs:(%rax)
│ 14006e95d: add %dl,0x6f(%rax,%rax,1)
│ 14006e961: add %dh,0x0(%rdx)
│ 14006e964: and %al,(%rax)
│ 14006e966: push %rax
│ 14006e967: add %dh,0x0(%rdx)