Skip to content

Bug 41329: Support new no_install_recommends RBM option, set it for linux-aarch64 firefox

NoisyCoil requested to merge NoisyCoil/tor-browser-build:bug_41329 into main

Merge Info

Issues

Resolves

Related

Merging

Target Branches

  • main: esr128-14.5
  • maint-14.0: esr128-14.0
  • maint-13.5: esr115-13.5

Backporting

Timeline

  • No Backport (preferred): patchset for the next major stable
  • Immediate: patchset needed as soon as possible
  • Next Minor Stable Release: patchset that needs to be verified in nightly before backport
  • Eventually: patchset that needs to be verified in alpha before backport

(Optional) Justification

  • Emergency security update: patchset fixes CVEs, 0-days, etc
  • Censorship event: patchset enables censorship circumvention
  • Critical bug-fix: patchset fixes a bug in core-functionality
  • Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
  • Sponsor required: patchset required for sponsor
  • Other: please explain

Issue Tracking

Review

Request Reviewer

  • Request review from an applications developer depending on modified system:
    • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
    • accessibility : henry
    • android : clairehurst, dan
    • build system : boklm
    • extensions : ma1
    • firefox internals (XUL/JS/XPCOM) : jwilde, ma1
    • fonts : pierov
    • frontend (implementation) : henry
    • frontend (review) : donuts, morgan
    • localization : henry, pierov
    • macOS : clairehurst, dan
    • nightly builds : boklm
    • rebases/release-prep : boklm, dan, ma1, morgan, pierov
    • security : jwilde, ma1
    • signing : boklm, morgan
    • updater : pierov
    • windows : jwilde, morgan
    • misc/other : morgan, pierov

Change Description

This MR fixes the linux-aarch64 nightly build failure described in #41329 (closed) by not installing recommended dependencies in the linux-aarch64 firefox container. Since there is no such functionality in RBM, I implemented it and opened an issue there (rbm#40081 (closed)), but forks and MRs are disabled in RBM I've reached my fork limit, so I'm submitting the following patch here instead: 0001-Bug-40081-Add-apt-option-to-not-install-package-recomm.patch. If the latter is accepted into RBM, the first commit in the present MR implements the changes needed in container-image project, and the second one uses the new functionality in firefox, limited to linux-aarch64.

In the RBM patch I used spaces in such a way that these changes should avoid rebuilds, but another pair of eyes on this might be beneficial. Also, I'm not including the commit to update the rbm submodule.

How Tested

Built a linux-aarch64 torbrowser nightly with binfmt_misc disabled, patching RBM as attached above, and adding a commit to update the rbm submodule.

Edited by boklm

Merge request reports

Loading