Draft: Bug 40056: Download .aar and .jar files for all .pom files

The process we use to generate gradle-dependencies-list.txt files is often missing .aar and .jar files corresponding to .pom files. To avoid that, we can try to download .aar and .jar files for all .pom files.

This adds some .aar and .jar files that we don't really need, but it should solve #40056.

Closes #40056

added Needs Review label

requested review from @sysrqb

assigned to @boklm

@boklm @sysrqb curious -- any blockers to merging this? (seems like it would have been helpful avoiding pitfals in the v96 build, ie: tor-browser!243 (comment 2770413))

@boklm @sysrqb curious -- any blockers to merging this? (seems like it would have been helpful avoiding pitfals in the 96 build, ie: tor-browser!243 (comment 2770413))

I don't see any blockers and it's included it in my mozilla96 branch.

This solves the issue with missing .aar and .jar files. But there are still cases where it's the .pom file that is missing, which is not fixed.

So are we good here?

mentioned in issue #40418 (closed)

requested review from @pierov and removed review request for @sysrqb

@pierov can you have a look at this either merge or close?

/cc @dan

I'd tend to close this, for two reasons:

1. we should check <packaging> in the pom, instead, and if we don't we could have troubles, see #40582 (comment 2823573)
2. I don't like this script:
   1. it often fails on my network (because of some CDN nonsense?);
   2. it doesn't re-use already-downloaded artifact: we should aim at a shared pool between all Java projects, and then we should add to the container only the files that project needs from it.

I have a Python script that already tries to share dependencies files between Java projects, but I call it externally of the build process.

I think we could improve it to be part of it, instead: fix_gradle_deps.py (e.g., in the regex for hashes I used [a-z0-9] instead of [a-fA-F0-9], etc etc etc).

removed Needs Review label

added Needs Revision label

marked this merge request as draft

closed