Bug 40679&40713: Inject torbutton translations in tor-browser-build and always use the most fresh translations for nightly builds
We are finally moving to Weblate!
As a consequence, we group all files in a single branch, and injecting them directly from tor-browser-build becomes possible.
However, I wonder if we could use only a single project for all translations.
Also, since I was at it, I've updated the other translation projects to fetch using the branch name in nightlies, so translators can have a quicker feedback.
Closes #40679 (closed) #40713 (closed).
/cc @boklm
Merge request reports
Activity
assigned to @pierov
added 1 commit
- f4c849b6 - Bug 40713: Inject torbutton translations during the build
However, I wonder if we could use only a single project for all translations.
Yes, I think we can. I did that in boklm/tor-browser-build@2e28f03b
I have not checked with a full build that it is actually working. I only tested a few commands like:
./rbm/rbm showconf translation git_hash --target nightly --step tba./rbm/rbm showconf translation git_hash --target alpha --step tor-browser./rbm/rbm showconf translation git_hash --target nightly --step base-browser
For some reason the template engine didn't like the string concatenation.
I have fixed it with another
fixup!and updated the git hashes because I've been doing several changes on translation.git that are needed for all of this to work.Linux x86_64 works. Now I am still building Android.
added 1 commit
- 417e235c - fixup! Bug 40713: Inject torbutton translations during the build
mentioned in merge request tor-browser!483 (merged)
added 1 commit
- 1678f6b2 - fixup! Bug 40713: Inject torbutton translations during the build
added 1 commit
- 3ebb8c75 - fixup! Bug 40713: Inject torbutton translations during the build
-
I think that replacing tba with fenix would be a good idea, since we don't use tba anywhere else, and in this way we immediately understand the consumer of the package.
Also, it's more consistent with the name of the translation.git branch.
Anyway, I've checked also Android (armv7 only) now, and it's correctly translated. In any case, this is needed for the alpha.
-
I think that replacing tba with fenix would be a good idea, since we don't use tba anywhere else, and in this way we immediately understand the consumer of the package.
Also, it's more consistent with the name of the translation.git branch.
Anyway, I've checked also Android (armv7 only) now, and it's correctly translated. In any case, this is needed for the alpha.
requested review from @ma1
requested review from @richard
added 6 commits
-
41455d96...2318e242 - 4 commits from branch
tpo/applications:main - a6590b11 - Bug 40679: Always use the latest available translations for nightly builds
- 3c1e96d7 - Bug 40713: Inject torbutton translations during the build
-
41455d96...2318e242 - 4 commits from branch
