Skip to content

Bug 40942: Do not customize git_hash for Base Browser

Pier Angelo Vendrame requested to merge pierov/tor-browser-build:bug_40942 into main

Merge Info

Related Issues



  • Immediate: patchset needed as soon as possible
  • Next Minor Stable Release: patchset that needs to be verified in nightly before backport
  • Eventually: patchset that needs to be verified in alpha before backport
  • No Backport (preferred): patchset for the next major stable

(Optional) Justification

  • Emergency security update: patchset fixes CVEs, 0-days, etc
  • Censorship event: patchset enables censorship circumvention
  • Critical bug-fix: patchset fixes a bug in core-functionality
  • Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
  • Sponsor required: patchset required for sponsor
  • Other: please explain

Issue Tracking


Request Reviewer

  • Request review from an applications developer depending on modified system:
    • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
    • accessibility : henry
    • android : dan
    • build system : boklm
    • extensions : ma1
    • firefox internals (XUL/JS/XPCOM) : ma1
    • fonts : pierov
    • frontend (implementation) : henry
    • frontend (review) : donuts, richard
    • localization : henry, pierov
    • nightly builds : boklm
    • rebases/release-prep : dan_b, ma1, pierov, richard
    • security : ma1
    • signing : boklm, richard
    • updater : pierov
    • misc/other : pierov, richard

Change Description

I think we don't need to customize git_hash for Base Browser.

The comment is only partially correct: we usually don't tag additional -buildN, but it was written before we had the branch.

Moreover, the hash clashes with the nightly target (which is eventually used, but it's somehow confusing).

The only use-case for build1 is to build a base browser alpha (or release), but we never do it, and we'll probably want to use the branch also in that case, rather than building at build1 (i.e., just after the rebase).

Edited by Pier Angelo Vendrame

Merge request reports