Skip to content

Bug 41053: Use Go 1.20 on Windows, except for Snowflake

Pier Angelo Vendrame requested to merge pierov/tor-browser-build:bug_41053 into main

Merge Info

Related Issues



  • Immediate: patchset needed as soon as possible
  • Next Minor Stable Release: patchset that needs to be verified in nightly before backport
  • Eventually: patchset that needs to be verified in alpha before backport
  • No Backport (preferred): patchset for the next major stable

(Optional) Justification

  • Emergency security update: patchset fixes CVEs, 0-days, etc
  • Censorship event: patchset enables censorship circumvention
  • Critical bug-fix: patchset fixes a bug in core-functionality
  • Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
  • Sponsor required: patchset required for sponsor
  • Other: please explain

Some Windows 7/8 users are without PTs, and Go 1.21.5 might have made the situation worse.

Issue Tracking


Request Reviewer

  • Request review from an applications developer depending on modified system:
    • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
    • accessibility : henry
    • android : clairehurst, dan
    • build system : boklm
    • extensions : ma1
    • firefox internals (XUL/JS/XPCOM) : ma1
    • fonts : pierov
    • frontend (implementation) : henry
    • frontend (review) : donuts, richard
    • localization : henry, pierov
    • macos : clairehurst, dan
    • nightly builds : boklm
    • rebases/release-prep : boklm, dan, ma1, pierov, richard
    • security : ma1
    • signing : boklm, richard
    • updater : pierov
    • misc/other : pierov, richard

Change Description

Up until 8867fa20, we used two different Go versions for Android and desktop.

So, I've started from that situation and adapted to use Go 1.20 on Windows, except for Snowflake.

By checking the AC team repos, it seems to me Lyrebird requires 1.20, Conjure 1.17 and Webtunnel 1.18. Only Snowflake requires 1.21. But since we got reports only for Windows, for other platforms I kept 1.21.

How Tested

Ran the following commands and verified they use the expected Go version:

rbm/rbm build lyrebird --target alpha --target torbrowser-windows-x86_64 # 1.20.12
rbm/rbm build snowflake --target alpha --target torbrowser-windows-x86_64 # 1.21.5
rbm/rbm build conjure --target alpha --target torbrowser-windows-x86_64 # 1.20.12
rbm/rbm build lyrebird --target alpha --target torbrowser-linux-x86_64 # 1.21.5
Edited by Pier Angelo Vendrame

Merge request reports