Skip to content

Draft: Bug 41071: Customize the default GTK font on Linux.

Pier Angelo Vendrame requested to merge pierov/tor-browser-build:bug_41071 into main

Merge Info

Related Issues

  • tor-browser#
  • mullvad-browser#xxxxx
  • #41071

Backporting

Timeline

  • Immediate: patchset needed as soon as possible
  • Next Minor Stable Release: patchset that needs to be verified in nightly before backport
  • Eventually: patchset that needs to be verified in alpha before backport
  • No Backport (preferred): patchset for the next major stable

(Optional) Justification

  • Emergency security update: patchset fixes CVEs, 0-days, etc
  • Censorship event: patchset enables censorship circumvention
  • Critical bug-fix: patchset fixes a bug in core-functionality
  • Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
  • Sponsor required: patchset required for sponsor
  • Other: please explain

Issue Tracking

Review

Request Reviewer

  • Request review from an applications developer depending on modified system:
    • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
    • accessibility : henry
    • android : clairehurst, dan
    • build system : boklm
    • extensions : ma1
    • firefox internals (XUL/JS/XPCOM) : ma1
    • fonts : pierov
    • frontend (implementation) : henry
    • frontend (review) : donuts, richard
    • localization : henry, pierov
    • macos : clairehurst, dan
    • nightly builds : boklm
    • rebases/release-prep : boklm, dan, ma1, pierov, richard
    • security : ma1
    • signing : boklm, richard
    • updater : pierov
    • misc/other : pierov, richard

Change Description

Set the default font to Arimo also for GTK.

It fixes the updater, but sadly it doesn't fix the "Save As" dialog.

How Tested

Created two nightly builds with this fix, and checked that updating the first one to the second one will show a sans-serif font instead of a serif font (Arimo, I think, but it's hard to tell):

https://tb-build-03.torproject.org/~pierov/mullvadbrowser/nightly/tbb-nightly.2024.01.01/

(I've removed the incremental to make sure the window is visible long enough).

Screenshot_from_2024-01-29_12-57-52

Edited by Pier Angelo Vendrame

Merge request reports