FF97 Audit

General

The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java/Kotlin, and Javascript).

The output includes the entire patch where the new problematic code was introduced. Search for XXX MATCH XXX to find the next potential violation.

code_audit.sh contains the list of known problematic APIs. New usage of these functions are documented and analyzed in this audit.

Firefox: https://github.com/mozilla/gecko-dev.git

• Start: e6b83e1727b7e9a6847e6e15bdb935d9937099e4 ( FIREFOX_RELEASE_97_BASE )
• End: 82764d45153d175f4686ead7aac977810fe1fd1b ( FIREFOX_RELEASE_98_BASE )

Languages:

• java
• cpp
• js
• rust

Nothing of interest (using code_audit.sh)

OR

foreach PROBLEMATIC_HASH:

$(PROBLEMATIC_HASH)

• Summary
• Review Result: (SAFE|BAD)

---

Application Services: https://github.com/mozilla/application-services.git

• Start: df53ad867be7d79899e05797533cd624f1eeb2a2 ( v90.0.1 )
• End: 17942945873cdb8be56a9316d3cb8a611b3ef321 ( v91.1.0 )

Languages:

• java
• cpp
• js
• rust

Nothing of interest (using code_audit.sh)

Android Components: https://github.com/mozilla-mobile/android-components.git

• Start: 604152ef532c33d8fc2412fd6d21cf29e9764c51 ( v97.0.0 )
• End: 0465a6f809adafd5429c230e890e7f4911f0070e ( v97.0.13 )

Languages:

• java
• cpp
• js
• rust

Nothing of interest (using code_audit.sh)

Fenix: https://github.com/mozilla-mobile/fenix.git

• Start: 84d4a07c0067f7c51757b157c79658a891870d95 ( v97.0.0-beta.1 )
• End: 16042ab2a16a64c9c94c8c01ea93578062415ac5 ( releases_v97.0.0 )

Languages:

• java
• cpp
• js
• rust

Nothing of interest (using code_audit.sh)

Ticket Review

Review List

97 https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&resolution=FIXED&target_milestone=97%20Branch&order=priority%2Cbug_severity&limit=0

• https://bugzilla.mozilla.org/show_bug.cgi?id=1741428 @richard tor-browser#41130 (closed)
• https://bugzilla.mozilla.org/show_bug.cgi?id=1738983 @pierov tor-browser#41131 (closed)
• https://bugzilla.mozilla.org/show_bug.cgi?id=1432983 @pierov tor-browser#41132 (closed)
• https://bugzilla.mozilla.org/show_bug.cgi?id=1745092 @boklm tor-browser#41133 (closed)

Nothing of interest (manual inspection)

OR (foreach)**

foreach PROBLEMATIC_TICKET:

$(PROBLEMATIC_TICKET)

• Summary
• Review Result: (SAFE|BAD)

Regression/Prior Vuln Review

Review proxy bypass bugs; check for new vectors to look for:

• https://gitlab.torproject.org/groups/tpo/applications/-/issues?scope=all&utf8=%E2%9C%93&state=opened&label_name[]=Proxy%20Bypass
  • Look for new features like these. Especially external app launch vectors

Export

• Export Report and save to tor-browser-spec/audits