Investigate+possible revert fix for Bugzilla 1732388

Introduced in Firefox 94: Bug 1732388 - support a proxy bypass flag for http requests

https://bugzilla.mozilla.org/show_bug.cgi?id=1732388

added Proxy Bypass label

assigned to @pierov

Git commit hash is efe27c10

Please check also Bugzilla 1732792 (beed7765).

It introduces a preference (network.proxy.allow_bypass) that disables this "feature" (anti-feature for us?) in toolkit/modules/ServiceRequest.jsm. Please notice that we already disabled it on desktop (#40682 (closed)), but not on Android!

I'd change netwerk/protocol/http/{HttpBaseChannel.cpp,nsHttpChannel.cpp} to ignore the request to use this flag anyway to be on the safe side.

First, I'd make the HTTP channel return NS_ERROR_NOT_IMPLEMENTED from GetBypassProxy/SetBypassProxy like the dummy channel, to avoid future conflicts/compilation errors, in case new parts of the code start using these functions.

On the other hand, having errors at the rebase/first build attempt would be helpful, because it would make us spot immediately such changes.

Then, I'd revert the change in nsHttpChannel.cpp, and set the new network.proxy.allow_bypass to false, to avoid any error due to the not implemented.

efe27c10 introduced also tests on the feature... Should I revert them?

sounds like a plan

https://blog.torproject.org/new-release-tor-browser-1057/#comment-292886

mentioned in merge request !286 (merged)

Merged in v96 for the stable.

For v99 we could modify the tests, to make them work as we intend (i.e., that the proxy is never bypassed), as @richard just suggested on IRC.

mentioned in issue tor-browser-build#40462 (closed)

marked this issue as related to #40682 (closed)

Mozilla added the check for network.proxy.allow_bypass (which we set for #40682 (closed)) to the C++ code, so this issue was v96-only.

For v99 and following we just need to set the preference (which we did, for example, in 11.5a10).

closed

mentioned in issue #41124 (closed)