Bookmarks manager broken in 12.0a2 on MacOS

A forum user has reported that they cannot import bookmarks using 12.0a2 on MacOS. On investigation it looks like the entire bookmarks manager is bugged out – with the window reading the following error:

To reproduce, click Bookmarks > Manage Bookmarks. Could someone check to see if this is MacOS specific, or occurs on other platforms too?

changed milestone to %Tor Browser 12.0

added Bug MacOS Next Q3 FF102-esr labels

changed title from Bookmarks manager completely broken in 12.0a2 on MacOS to Bookmarks manager broken in 12.0a2 on MacOS

worksforme windows

@fabrizio to confirm macOS

edit: you can just paste chrome://browser/content/places/places.xhtml into the urlbar

OP here. MacOS version for original report is 10.13.6 High Sierra. Haven’t tried it on any other versions. Looks like @duncan may have tried a later version (Big Sur or Monterey?). NB that 10.13.6 is no longer supported by Apple and was the last version where the system was all on one drive. Backporting to it can be tricky. Subsequent versions split the drive into two volumes: system and data. When I paste chrome://browser/content/places/places.xhtml in the url bar it returns the same error but in the window:

reproduced on macOS Monterey 12.5.1 using TB 12.0a2:

mentioned in issue #41313 (closed)

removed Q3 label

added Q4 label

removed Next label

added Backlog label

changed milestone to %Sponsor 131 - Phase 3 - Major ESR 102 Migration

assigned to @henry

I think this is because it is missing the entities from torbutton.dtd.

Specifically, #menu_newCircuit is from browser-menubar.inc. This file is included in browser.xhtml via navigator-toolbox.inc.xhtml. On mac only it is also included in places.xhtml via macWindow.inc.xhtml https://gitlab.torproject.org/tpo/applications/tor-browser/-/blob/bdbc21560c1acf258bd83116c370e66b037dd1a5/browser/components/places/content/places.xhtml#L58.

This file needs strings from torbutton.dtd, which is brought into scope by browser-doctype.inc. This is included in browser.xhtml https://gitlab.torproject.org/tpo/applications/tor-browser/-/blob/bdbc21560c1acf258bd83116c370e66b037dd1a5/browser/base/content/browser.xhtml#L44, but not places.xhtml. Hence the error on macos. So including browser-doctype.inc in places.xhtml or macWindow.inc.xhtml might solve it.

At least that's what I think is happening. I haven't got macos to test if it may be something else. I just read the code.

@pierov I couldn't see a change in mozilla-central that would have triggered this. Could it have happened whilst moving parts of torbutton into tor-browser?

Moz completely removed DTDs in a bunch of places. I've restored them when rebasing to 102, but I might have missed some.

assigned to @pierov and unassigned @henry

removed Backlog label

added Next label

91.13 have browser-doctype.inc in these places:

• browser/base/content/aboutDialog.xhtml
• browser/base/content/browser.xhtml
• browser/base/content/hiddenWindowMac.xhtml
• browser/base/content/pageinfo/pageInfo.xhtml
• browser/components/places/content/places.xhtml
• browser/components/shell/content/setDesktopBackground.xhtml
• toolkit/mozapps/update/content/updateElevation.xhtml --> Not restoring on purpose

(see https://gitlab.torproject.org/search?search=browser-doctype.inc&nav_source=navbar&project_id=472&group_id=477&search_code=true&repository_ref=tor-browser-91.13.0esr-11.5-1)

mentioned in merge request !406 (merged)

added Doing label and removed Next label

marked this issue as related to tor-browser-build#40627 (closed)

closed

removed Doing label

mentioned in issue #41407 (closed)

mentioned in merge request !475 (merged)

marked this issue as related to tor-browser-build#40985 (closed)

marked this issue as related to tor-browser-build#40987 (closed)

removed the relation with tor-browser-build#40985 (closed)

removed the relation with tor-browser-build#40987 (closed)