Re-enable screenshots component

If one opens the context menu with a right-click on any website you have the option to take a screenshot in Firefox. That's not available in Tor Browser for desktop. I know we restrict the screenshot functionality on Android (#41195 (closed)) but there is no reason to do the same for desktop, I think. This results in me needing to resort to plain Firefox when trying to take a screenshot of some Grafana boards :( (see: tpo/tpa/team#40866 (closed) for the TPA issue with some discussion).

changed the description

changed title from There is no option available to take a screenshot( via the context menu) in Tor Browser to There is no option available to take a screenshot (via the context menu) in Tor Browser

I'm inclined to agree, IIRC the screenshot UX was originally quite confusing as the default download'y looking button actually uploaded to the cloud but that seems to be gone, so we should bring this back.

added Q4 label

added Sponsor 131 UX FF102-esr labels

changed milestone to %Sponsor 131 - Phase 3 - Major ESR 102 Migration

added Task label

added Next label

Screenshots are disabled due to fingerprinting concerns, it's #40007 (closed), #40912 (closed)

Seems like that leak should be fixed what the hell

added Uplift label

removed Next label

removed Q4 label

added Backlog label

removed Sponsor 131 label

added Fingerprinting label

changed milestone to %Sponsor 131 - Phase 5 - Ongoing Maintenance

@thorin is there an upstream bug for this?

no, extensions.screenshots.disabled is set to false true in TB, so it's working as intended - no bug

no, I mean for the underlying issue where websites can even tell you're taking a screen shot (let alone fingerprint you off it somehow)

https://bugzilla.mozilla.org/show_bug.cgi?id=1717671#c0

removed Backlog label

added Sponsor 131 Roadmap::Future labels

removed FF102-esr label

added Bug Upstream labels

removed Task label

added Desktop label

So nightly 125 currently has a new screenshots, built in, so we should test that in our ESR128 builds, as it should no longer leak a UUID

1696573 [Meta] Move screenshots into a dedicated browser component

I don't want to mess up all the labels ... can we remove bug and add ESR128 and maybe edit title? @richard

edit: or should I just log a new issue to investigate in ESR128 ?

https://earthlng.github.io/testpages/screenshots_FP.html

cleaning up as I see fit .. undo if you don't like it

YES 🤩

built in screenshots component enabled by default FF127+ https://hg.mozilla.org/mozilla-central/rev/0b3d9d06650b

we would also want to fix 1780910 screenshot zoomed/cropped when resistFingerprinting enabled (devicePixelRatio thing)

needs testing - https://bugzilla.mozilla.org/show_bug.cgi?id=1780910#c6 - apparently this is not a thing anymore?

• edit: tested by tim - will be interesting to see if it lines up nicely with letterboxing matte showing and viewport centered

Hey it works, I'll see about re-enabling in a patch tomorrow.

changed title from There is no option available to take a screenshot (via the context menu) in Tor Browser to {+ESR128: check screenshots.browser.component.enabled = true and restore screenshots menu+}

removed Bug label

removed Uplift label

removed Upstream label

removed UX label

added FF128-esr label

removed Fingerprinting label

mentioned in issue #42054 (closed)

changed title from ESR128: {-check -}screenshots{-.browser.component.enabled = true and restore-} screenshots menu to ESR128: renable screenshots + menu: lock pref to use built-in screenshots component

added Task label

changed title from ESR128: renable screenshots + menu: lock pref to use built-in screenshots component to ESR128: re-enable screenshots + menu: lock pref to use built-in screenshots component

added 14.0 stable Backlog labels

removed Roadmap::Future label

mentioned in issue #42616 (closed)

removed 14.0 stable label

added 14.0 stable label

mentioned in issue #42752 (closed)

marked this issue as related to #42752 (closed)

marked this issue as related to #42751 (closed)

mentioned in issue #42751 (closed)

removed Backlog label

added Next label

assigned to @morgan