Add a title to the new identity confirmation

The new identity prompt has an English title also in (some?) non-English languages, e.g., in Italian and in Spanish (Spain):

The reason is that we leave empty the second argument of Services.prompt.confirmEx, but maybe it isn't translated in all languages.

We don't control that translation, so I suggest we add our own title to that window.

assigned to @henry

@henry I'm assigning it to you because from what I've understood you're working on New Identity strings at the moment, or you're going to work on it soon.

Yeah, this should be easy. Since this isn't a major issue, we could wait until after !374 (closed) lands and we have the fluent file on weblate and see how our new process handles adding a fluent entry to an existing fluent file.

It's a smart move.

/cc @emmapeel

Now that I think of it, this prompt is the old one.

When tor dies we have a more recent one that is also better looking. Still, it might need strings for the buttons.

Yep, here's an example of the current Proton modal:

I think you just need to give window as the first argument to confirmEx to get the new styling.

Awesome, fyi I've split it out into a separate ticket here: #41342 (closed)

added Sponsor 131 label

changed milestone to %Sponsor 131 - Phase 3 - Major ESR 102 Migration

changed milestone to %Sponsor 131 - Phase 2 - Privacy Browser

added Localization UX labels

added Next Q4 labels

marked this issue as related to #41342 (closed)

I think "Confirm" is a bad title in English too. How about:

Reset your identity?

I've also just noticed how the checkbox behavior is the inverse of Firefox's in the screenshot I posted above. Ideally, these would be consistent, i.e.:

[] Warn before restarting Tor Browser

We should also translate Yes and No by ourselves.

So @duncan if you prefer anything else also for them just say it .

Oh yeah, the button strings are bad as well

These should read something like:

[Cancel] [Restart Tor Browser]

In that order. The rightmost should also be in primary blue, but that sounds like more of a task for #41342 (closed).

assigned to @pierov and unassigned @henry

removed Next label

added Doing label

mentioned in merge request !393 (merged)

marked this issue as related to tor-browser-build#40627 (closed)

closed

removed Doing label