Skip to content

Missing onionAuthViewKeys causes "Onion Services Keys" dialog to be empty.

Problem

I saw this in my local dev build.

Steps to reproduce

  1. Save an onion authentication key when prompted to enter one.
  2. Open Privacy preferences and navigate to "Onion Services Authentication".
  3. Click "Saved Keys...".

Result

The dialog's table is empty with the message below it that says "Unable to retrieve keys from tor".

Expect

The saved keys to be shown.

Origin

This is the line that throws https://gitlab.torproject.org/tpo/applications/tor-browser/-/blob/7f80a8d34c6c9bb0afbc4220faf1266a97bd9763/browser/components/onionservices/content/savedKeysDialog.js#L136 because the onionAuthViewKeys method is missing. Since this is in a large try block, the error gets turned into a generic message shown to the user.