Empty the clipboard on browser shutdown only if content comes from private browsing windows

The user may not expect or need this feature (#42019 (closed)) and maybe it should additionally be disabled for non-private browsing mode.

One issue is that the clipboard is emptied even if its contents did not originate from a browser.

changed the description

assigned to @ma1

added Needs Information label

added 13.0 stable 13.5 stable Backport Roadmap::Future labels

@ma1 my understanding was that the clipboard only is cleared of contents that originated from the browser?

closed

reopened

added Windows label

added Bug label

added MacOS label

changed title from Consider making it optional to empty the clipboard on browser shutdown to Empty the clipboard on browser shutdown only if content comes from the browser in PBM.

added Doing label

mentioned in merge request !834 (merged)

changed title from Empty the clipboard on browser shutdown only if content comes from the browser in PBM. to Empty the clipboard on browser shutdown only if content comes from private browsing windows

marked this issue as related to tor-browser-build#40981 (closed)

marked this issue as related to tor-browser-build#40978 (closed)

marked this issue as related to tor-browser-build#40985 (closed)

marked this issue as related to tor-browser-build#40987 (closed)

@ma1 when you get the chance, can you verify this is ready for backporting to stable?

Meaning that we don't have alpha users complaining (in other gitlab issues or in the forum) about regressions or unexpected behavior?

Checked, and it doesn't seem we've got any complaint either in the tracker or in the forum. Let's backport it!

(i.e. I am cherry-picking it on the stable branches)

@ma1 I don't know if it can be fixed but when I open the browser in a VM and then copy something on the host machine which shares the clipboard with the VM, the clipboard is incorrectly getting emptied.

Wow now that is a wild interaction. So basically the browser doesn't register its lost focus because the entire client OS has lost focus?

Wow now that is a wild interaction. So basically the browser doesn't register its lost focus because the entire client OS has lost focus?

Exactly.

I've got some ideas for in 13.5 stable (whose feasibility is still to be checked), but the current situation is anyway an improvement on wiping any clipboard data indiscriminately.

@cypherpunks1 could you please open a separate issue and assign it to me? Thanks!

removed Needs Information label

closed

mentioned in issue #42254