newwin: bookmarks toolbar doesn't elegantly handle all app languages

so for those without letterboxing for example, the sizes can be off if not en-US. On my devicePixelRatio 1 desktop, in a linux VM, when starting in fa (as an example) the inner window is 10pixels too tall

this was all on Linux

digging a little deeper

  • when toolbar is never shown everything is peachy
    • both first newwin and menu>new window
  • when toolbar is set to always show, some app languages are approx 10px off (may vary per machine)
    • I found ar, fa, ga-IE, ko, th, zh-CN and zh-TW to be affected
    • I wasn't specifically testing for this and required letterboxing to be on so I may have missed some or ones that are even 1px out
    • both first newwin and menu>new window

when the toolbar is set to show only on new tabs (default) things get messy (also see #42192 (closed))

  • newwin on startup is fine
  • menu> new window is shows the same 10px effect but coupled with #42192 (closed)
    • the height dropped from 900px to 840px but I'm 99% sure this was because my VM window was just the wrong size and triggered a smaller 800px attempt (due to the extra height) which was 30px for the toolbar and outr mysterious 10px

So again, we should be measuring after any newwin creating and then resizing a second time if needed (should be feasible, see other tickets)

cc: @ma1 @pierov

Edited by Thorin