This has happened at least twice to me, but I have no idea how to reproduce it.
On first launch, the viewport in Tor Browser 13.0 is 900px high and unletterboxed. After a period of several days, an additional 30px appears to get added to the height of the overall window, increasing the viewport to 930px and triggering letterboxing.
Note: this is not due to changes in the height of the browser chrome eating into the viewport (e.g. the bookmarks bar being on or off), as the height of the entire window has increased by 30px.
Tor Browser will then reliably reopen itself at the new dimensions even when quit and relaunched. Wiping the TorBrowser-Data file from macOS' Application Support folder seems to reset the browser back to its original dimensions, however.
you leave it open for several days? I'm sure that's not what you meant, right?. You mean it's not always producible, but each time it's a brand new TB start - right?
30px sounds suspiciously like a toolbar height. What is your toolbar set to - always show, never show, or only on new tabs? Only on new tabs is the default - and it is this toggle state that I'm interested in. Not saying the toolbar is eating into any space, just saying that maybe this is the element/cause.
you leave it open for several days? I'm sure that's not what you meant, right?. You mean it's not always producible, but each time it's a brand new TB start - right?
I mean to say it occurs at some point over several days of normal usage, which for me includes multiple quits, relaunches, system restarts etc.
However it doesn't seem to happen with a fresh install of TB 13.0.
30px sounds suspiciously like a toolbar height. What is your toolbar set to - always show, never show, or only on new tabs? Only on new tabs is the default - and it is this toggle state that I'm interested in. Not saying the toolbar is eating into any space, just saying that maybe this is the element/cause.
My toolbar's set to the new defaults – i.e. show on new tab. However the dimensions of the overall window are 30px higher regardless of whether or not the toolbar is visible.
Could the change to display it on new tab me messing up the window height calculations?
regardless of whether or not the toolbar is visible.
as I said
Not saying the toolbar is eating into any space, just saying that maybe this is the element/cause
So this is being used to determine measurements before it is shown/hidden - some sort of race, which explains the hard to reproduce. For example, I can't replicate - and I even made my window 30px taller, before closing. Mind you, I always set my toolbar to always show. BBiaB .. testing
IIUIC, the startup size and position is read from profile\xulstore.json (not sure when it is written to, on close for last positions, on demand for column sizes? IDK) - and mac doesn't close by default, I have to right-click and quit
So it's possible the xulstore.json file starts it in a bad state once it gets in that state, but this is likely a symptom/red-herring of the cause
about:tor is not the first page on startup - it's the one with the connect button. about:tor shows a toolbar (so would cause 30px extra height). the connect page does not show the toolbar. but if you open a new window after connecting, it will see the toolbar....
we seem to treat some pages differently to others?
bad news
it's not hard to end up in a "bad" newwin state
good news
LBing saves us
bad news
donut's and others can get stuck in a bad newwin (can't replicate)
STR on desktop (any OS)
setup
set bookmarks toolbar to only show on new tab
disable auto connection
turn off letterboxing
close
open
you should be on the connection page
note: no toolbar
the size should be e.g. 1400 x 900
connect
you should be on about:tor (if you didn't change your landing page)
note: the toolbar is showing
the size is now 1400 x 870 (or whatever depending on your OS)
load TZP
no toolbar - so 1400 x 900 = all good
now go hamburger> new window
we did not use the connect page, so the toolbar is shown on the default new tab
and thus newwin sets the size using that = now taller (by the toolbar height) than the previous window
load TZP
no toolbar - so 1400 x 930 = no good
important - change letterboxing back on, and the other settings to taste
for me on windows 11 the difference is 28px not 30px
EXTRA STR
close your original smaller window
then close the newer taller window and end TB's session
the last window will store the taller window in xulstore.json
I can't reproduce starting up at the bigger height (e.g. donut's 30px too tall), but maybe there's some sort of race condition with the last state of the toolbar/xulstore?
solutions
easiest solution: remove the option to only show on new tabs - i.e remove the UI line, and force the value in code (for those that change things in about:config) to use always or never
better solution: as I've said a dozen times already, we need a second newwin check and adjust if required - I said this with the 1px height diffs from system scaling, that we can never be sure if we should round up or down
any other solution is probably going to be super convoluted (e.g. custom newtab/home, opening new windows via right clicks and other bypasses and outcomes, such as interstitials etc)
better solution: as I've said a dozen times already, we need a second newwin check and adjust if required - I said this with the 1px height diffs from system scaling, that we can never be sure if we should round up or down
Thorinchanged title from Window mysteriously grows in height by 30px on macOS to bookmarks toolbar "only on new tabs" can cause newwin into a too tall (by toolbar height) state
changed title from Window mysteriously grows in height by 30px on macOS to bookmarks toolbar "only on new tabs" can cause newwin into a too tall (by toolbar height) state
donutschanged title from bookmarks toolbar "only on new tabs" can cause newwin into a too tall (by toolbar height) state to Bookmarks toolbar increases newwin height when set to show "Only on New Tabs"
changed title from bookmarks toolbar "only on new tabs" can cause newwin into a too tall (by toolbar height) state to Bookmarks toolbar increases newwin height when set to show "Only on New Tabs"
Thorinchanged title from Bookmarks toolbar increases newwin height when set to show "Only on New Tabs" to newwin: Bookmarks toolbar adds it's height to newwin height when set to show "Only on New Tabs"
changed title from Bookmarks toolbar increases newwin height when set to show "Only on New Tabs" to newwin: Bookmarks toolbar adds it's height to newwin height when set to show "Only on New Tabs"
ma1changed title from newwin: Bookmarks toolbar adds it's height to newwin height when set to show "Only on New Tabs" to newwin: Bookmarks toolbar adds its height to newwin height when set to show "Only on New Tabs"
changed title from newwin: Bookmarks toolbar adds it's height to newwin height when set to show "Only on New Tabs" to newwin: Bookmarks toolbar adds its height to newwin height when set to show "Only on New Tabs"
ma1changed title from newwin: Bookmarks toolbar adds its height to newwin height when set to show "Only on New Tabs" to Correctly round newwindows when bookmark toolbar is set to "Show Only on New Tab"
changed title from newwin: Bookmarks toolbar adds its height to newwin height when set to show "Only on New Tabs" to Correctly round newwindows when bookmark toolbar is set to "Show Only on New Tab"
ma1changed title from Correctly round new windows when bookmark toolbar is set to "Show Only on New Tab" to Correctly round new windows when bookmarks toolbar is set to "Show Only on New Tab"
changed title from Correctly round new windows when bookmark toolbar is set to "Show Only on New Tab" to Correctly round new windows when bookmarks toolbar is set to "Show Only on New Tab"
ma1changed title from Correctly round new windows when bookmarks toolbar is set to "Show Only on New Tab" to Correctly round new windows when bookmarks toolbar is set to "Only Show on New Tab"
changed title from Correctly round new windows when bookmarks toolbar is set to "Show Only on New Tab" to Correctly round new windows when bookmarks toolbar is set to "Only Show on New Tab"