Draft: Bug 42997: Do not fetch the git repository on every CI job
Merge Info
Related Issues
- #42997 (closed)
- mullvad-browser#xxxxx
- tor-browser-build#xxxxx
Backporting
Timeline
-
Immediate: patchset needed as soon as possible -
Next Minor Stable Release: patchset that needs to be verified in nightly before backport -
Eventually: patchset that needs to be verified in alpha before backport -
No Backport (preferred): patchset for the next major stable
(Optional) Justification
Let's backport this because it the big amount of fetches is causing Gitlab slowdows.
Merging
-
Merge to tor-browser
-!fixups
totor-browser
-specific commits, new features, security backports -
Merge to base-browser
-!fixups
tobase-browser
-specific commits, new features to be shared withmullvad-browser
, and security backports-
NOTE: if your changeset includes patches to both
base-browser
andtor-browser
please clearly label in the change description which commits should be cherry-picked tobase-browser
after merging
-
NOTE: if your changeset includes patches to both
Issue Tracking
-
Link resolved issues with appropriate Release Prep issue for changelog generation
Review
Change Description
The changes here were done in collaboration with @lavamind and @lelutin.
The main change is that now we copy the full repository into our docker container in a build-container job that runs before any other CI jobs. Subsequent CI jobs then have GIT_STRATEGY: none
meaning they do not fetch at all and just use what is in the container. This means a new container is pushed by the CI for each pipeline run.
Opening as a draft, because I want to wait for the replies on tpo/tpa/base-images#11 (closed) before marking this as ready to merge.
Also I just realized I should change the git strategy also for the translations CI jobs.
Initial comments accepted.
How Tested
If CI is green we are golden.
Related to #42997 (closed)