Skip to content

Bug 41817: tor-browser semantic colors.

henry requested to merge henry/tor-browser:tor-colors-bug-41817 into tor-browser-128.1.0esr-14.0-1

Merge Info

Related Issues

Backporting

Timeline

  • Immediate: patchset needed as soon as possible
  • Next Minor Stable Release: patchset that needs to be verified in nightly before backport
  • Eventually: patchset that needs to be verified in alpha before backport
  • No Backport (preferred): patchset for the next major stable

(Optional) Justification

  • Emergency security update: patchset fixes CVEs, 0-days, etc
  • Censorship event: patchset enables censorship circumvention
  • Critical bug-fix: patchset fixes a bug in core-functionality
  • Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
  • Sponsor required: patchset required for sponsor
  • Localization: typos and other localization changes that should be also in the release branch
  • Other: please explain

Merging

  • Merge to tor-browser - !fixups to tor-browser-specific commits, new features, security backports
  • Merge to base-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports
    • NOTE: if your changeset includes patches to both base-browser and tor-browser please clearly label in the change description which commits should be cherry-picked to base-browser after merging

Issue Tracking

Review

Request Reviewer

  • Request review from an applications developer depending on modified system:
    • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
    • accessibility : henry
    • android : clairehurst, dan
    • build system : boklm
    • extensions : ma1
    • firefox internals (XUL/JS/XPCOM) : jwilde, ma1
    • fonts : pierov
    • frontend (implementation) : henry
    • frontend (review) : donuts, richard
    • localization : henry, pierov
    • macOS : clairehurst, dan
    • nightly builds : boklm
    • rebases/release-prep : dan, ma1, pierov, richard
    • security : jwilde, ma1
    • signing : boklm, richard
    • updater : pierov
    • windows : jwilde, richard
    • misc/other : pierov, richard

Change Description

NOTE:

  1. "fixup! Bug 40925: Implemented the Security Level component" should be cherry-picked to the base-browser branch.
  2. "fixup! Bug 41659: Add canonical color definitions to base-browser" should also be cherry-picked to the base-browser branch, and eventually lead to the removal of the "Bug 41659: Add canonical color definitions to base-browser" commit entirely.

In this merge request we:

  1. Create the tor-colors.css stylesheet to include all the --purple (photon) colors, plus associating them with semantic names. We use this to replace all locations that previously used --purple variables.
  2. Dropped browser-colors.css. The --purple colors are used internally by tor-colors.css. The --warning-color can be replaced with --in-content-warning-icon-color for content or --warning-icon-bgcolor for chrome. The --grey-40 color only changed the breadcrumb arrows in "about:torconnect". Otherwise none of the other colors were used. They don't seem to be used in firefox-android either.
  3. Used tor-button class to style the tor url bar buttons, plus the buttons in "about:torconnect". A side effect is that "about:torconnect" now has a dark-theme variant for the buttons.
  4. Tidied up aboutTorConnect.css to remove the unused checkbox styling. Also dropped the "danger-button" styling, which did not seem useful for users. And no longer applied the "primary" class to the cancel button.

/cc @donuts

How Tested

I checked the different locations in the light and dark theme. Sometimes using the console to shortcut to seeing the orange warning icons in a few places.

Merge request reports