Skip to content

Bug 43099: 2024 Year End Campaign for Android

Merge Info

Related Issues

Backporting

Timeline

  • Immediate: patchset needed as soon as possible
  • Next Minor Stable Release: patchset that needs to be verified in nightly before backport
  • Eventually: patchset that needs to be verified in alpha before backport
  • No Backport (preferred): patchset for the next major stable

(Optional) Justification

  • Emergency security update: patchset fixes CVEs, 0-days, etc
  • Censorship event: patchset enables censorship circumvention
  • Critical bug-fix: patchset fixes a bug in core-functionality
  • Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
  • Sponsor required: patchset required for sponsor
  • Localization: typos and other localization changes that should be also in the release branch
  • Other: please explain

Merging

  • Merge to tor-browser - !fixups to tor-browser-specific commits, new features, security backports
  • Merge to base-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports
    • NOTE: if your changeset includes patches to both base-browser and tor-browser please clearly label in the change description which commits should be cherry-picked to base-browser after merging

Issue Tracking

Review

Request Reviewer

  • Request review from an applications developer depending on modified system:
    • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
    • accessibility : henry
    • android : clairehurst, dan
    • build system : boklm
    • extensions : ma1
    • firefox internals (XUL/JS/XPCOM) : jwilde, ma1
    • fonts : pierov
    • frontend (implementation) : henry
    • frontend (review) : donuts, richard
    • localization : henry, pierov
    • macOS : clairehurst, dan
    • nightly builds : boklm
    • rebases/release-prep : dan, ma1, pierov, richard
    • security : jwilde, ma1
    • signing : boklm, richard
    • updater : pierov
    • windows : jwilde, richard
    • misc/other : pierov, richard

Change Description

Implemented the 2024 YEC in compose.

3 styles in landscape and portrait

image image image

image image image image

Sample Burmese text. Note that this implementation does not get the glyph size to get the line height to draw the "highlight" behind the "rights text". I picked a line height that works for both English and Burmese text. I did not test other languages. Also note that Burmese text gets the bold effect, but is not affected by Space Grotesk font

image

How Tested

To see the 2024 YEC screen

  1. Change val startDate = dateFormat.parse("2024-10-14") in HomeScreenViewModel.kt:28 to a date in the past
  2. Comment out the && BuildConfig.BUILD_TYPE == "release" line in HomeScreenViewModel.kt:34 (or build in "release" mode)

Install, bootstrap, and verify that it looks good in different font sizes, screen sizes, screen orientations, android versions, languages.

Edited by clairehurst

Merge request reports