Skip to content

Bug 41066: isolate tor connections based on userContextId

trinity-1686a requested to merge trinity-1686a/tor-browser:containertab-isolation into tor-browser-102.6.0esr-12.5-1

fix #41066 (closed)

As is, these changes are useless to end users: TorBrowser always operate in private browsing mode, which Multi-Account Container does not support.

Rebuilding the extension and trying to do almost anything yields JavaScript error: undefined, line 0: Error: Illegal to set non-private cookieStoreId in a private window1.

Silencing that gives a JavaScript error: undefined, line 0: Error: Contextual identities are unavailable in permanent private browsing mode2 which relates to that ticket.

Silencing that too shows the changes works, but that's possibly unsafe for other reasons.

If we actually want to use containers, someone should probably comment upstream ticket to describe TB use case.

  1. https://gitlab.torproject.org/tpo/applications/tor-browser/-/blob/059f27f1086bb421d044fbb558d8e0c572207303/toolkit/components/extensions/parent/ext-tabs-base.js#L2299 ↩

  2. https://gitlab.torproject.org/tpo/applications/tor-browser/-/blob/059f27f1086bb421d044fbb558d8e0c572207303/toolkit/components/extensions/parent/ext-tabs-base.js#L2313 ↩

Merge request reports