Add new tor download warning to about:downloads and places.xhtml
Merged
requested to merge henry/tor-browser:download-warning-bug-41718 into tor-browser-102.12.0esr-12.5-1
All threads resolved!
Merge Info
-
-
-
Immediate - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build) -
Next Minor Stable Release - patchset that needs to be verified in nightly before backport -
Eventually - patchset that needs to be verified in alpha before backport -
No Backport - patchset for the next major stable
-
-
- No upstream merge.
-
-
Link resolved issues with appropriate Release Prep issue for changelog generation
-
Change Description
Taken from !634 (closed) and extended.
Edited by ma1
Merge request reports
Activity
requested review from @ma1
assigned to @henry
- Resolved by henry
Two stand outs:
- The Library button has different old styling. This is just because the default button styling is not in scope. I'm not sure it is worth importing all those button styling rules.
- The icon is center aligned with the message box, rather than aligned with the bold title. The mozilla
message-bar
element doesn't have an easy way to control this because the icon lives in a shadow root, so doesn't share the styling rules with the rest of the content. Do you think this alignment is "good enough", or would you want a different alignment?
added 3 commits
-
4bbc179a...968655c2 - 2 commits from branch
tpo/applications:tor-browser-102.12.0esr-12.5-1
- 787ac906 - amend! Bug 40701: Add in pane security warning when downloading a file
-
4bbc179a...968655c2 - 2 commits from branch
marked the checklist item Link resolved issues with appropriate Release Prep issue for changelog generation as completed
mentioned in issue #41820 (closed)
Please register or sign in to reply