Skip to content
Snippets Groups Projects

Add new tor download warning to about:downloads and places.xhtml

All threads resolved!

Merge Info

  • Related Issues

  • Backport Timeline

    • Immediate - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
    • Next Minor Stable Release - patchset that needs to be verified in nightly before backport
    • Eventually - patchset that needs to be verified in alpha before backport
    • No Backport - patchset for the next major stable
  • Upstream Merging

    • No upstream merge.
  • Issue Tracking

Change Description

Taken from !634 (closed) and extended.

Edited by ma1

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • henry requested review from @ma1

    requested review from @ma1

  • henry assigned to @henry

    assigned to @henry

    • Author Maintainer
      Resolved by henry

      @donuts

      Screenshot of downloads warning in library window

      Screenshot of downloads warning in about:downloads

      Two stand outs:

      1. The Library button has different old styling. This is just because the default button styling is not in scope. I'm not sure it is worth importing all those button styling rules.
      2. The icon is center aligned with the message box, rather than aligned with the bold title. The mozilla message-bar element doesn't have an easy way to control this because the icon lives in a shadow root, so doesn't share the styling rules with the rest of the content. Do you think this alignment is "good enough", or would you want a different alignment?
  • henry resolved all threads

    resolved all threads

  • Maintainer

    Great work @henry & @dan , thanks! Please rebase, and I'm gonna approve / merge.

  • ma1 added 3 commits

    added 3 commits

    • 4bbc179a...968655c2 - 2 commits from branch tpo/applications:tor-browser-102.12.0esr-12.5-1
    • 787ac906 - amend! Bug 40701: Add in pane security warning when downloading a file

    Compare with previous version

  • ma1 approved this merge request

    approved this merge request

  • Maintainer

    Rebased here (wanted to try the blue button!) :smile: Merging now...

  • ma1 merged

    merged

  • ma1 marked the checklist item Link resolved issues with appropriate Release Prep issue for changelog generation as completed

    marked the checklist item Link resolved issues with appropriate Release Prep issue for changelog generation as completed

  • henry mentioned in issue #41820 (closed)

    mentioned in issue #41820 (closed)

Please register or sign in to reply
Loading