Bug 42246: Migrate tor connection stuff from browser to toolkit
Merge Info
Related Issues
- #42246 (closed)
 - mullvad-browser#xxxxx
 - tor-browser-build#xxxxx
 
Backporting
Timeline
- 
Immediate: patchset needed as soon as possible  - 
Next Minor Stable Release: patchset that needs to be verified in nightly before backport  - 
Eventually: patchset that needs to be verified in alpha before backport  - 
No Backport (preferred): patchset for the next major stable  
(Optional) Justification
- 
Emergency security update: patchset fixes CVEs, 0-days, etc  - 
Censorship event: patchset enables censorship circumvention  - 
Critical bug-fix: patchset fixes a bug in core-functionality  - 
Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc  - 
Sponsor required: patchset required for sponsor  - 
Other: please explain  
Merging
- 
Merge to tor-browser-!fixupstotor-browser-specific commits, new features, security backports - 
Merge to base-browser-!fixupstobase-browser-specific commits, new features to be shared withmullvad-browser, and security backports- 
NOTE: if your changeset includes patches to both 
base-browserandtor-browserplease clearly label in the change description which commits should be cherry-picked tobase-browserafter merging 
 - 
NOTE: if your changeset includes patches to both 
 
Issue Tracking
- 
Link resolved issues with appropriate Release Prep issue for changelog generation  
Review
Request Reviewer
- 
Request review from an applications developer depending on modified system: - 
NOTE: if the MR modifies multiple areas, please 
/ccall the relevant reviewers (since gitlab only allows 1 reviewer) - accessibility : henry
 - android : clairehurst, dan
 - build system : boklm
 - extensions : ma1
 - firefox internals (XUL/JS/XPCOM) : ma1
 - fonts : pierov
 - frontend (implementation) : henry
 - frontend (review) : donuts, richard
 - localization : henry, pierov
 - macos : clairehurst, dan
 - nightly builds : boklm
 - rebases/release-prep : dan, ma1, pierov, richard
 - security : ma1
 - signing : boklm, richard
 - updater : pierov
 - misc/other : pierov, richard
 
 - 
NOTE: if the MR modifies multiple areas, please 
 
Not sure, maybe Henry could be a good reviewer?
Change Description
Rearranged a few files to be in toolkit (and therefore the omni.ja in the root, and Android's omni.ja, rather than browser/omni.ja).
Also, moved to JS modules a bunch of other files.
How Tested
Built, checked that we don't have errors in the console, checked that we can still bootstrap and that all the various about:preferences#connection features still work (+ a bunch of others, such as onion location, rulesets and onion authentication).