Persist closing the 2023 YEC banner for the rest of the session

Merge Info

Related Issues

• #42188 (closed)

Backporting

Timeline

• Immediate: patchset needed as soon as possible
• Next Minor Stable Release: patchset that needs to be verified in nightly before backport
• Eventually: patchset that needs to be verified in alpha before backport
• No Backport (preferred): patchset for the next major stable

(Optional) Justification

• Emergency security update: patchset fixes CVEs, 0-days, etc
• Censorship event: patchset enables censorship circumvention
• Critical bug-fix: patchset fixes a bug in core-functionality
• Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
• Sponsor required: patchset required for sponsor
• Other: The banner is not shown in alpha or nightly, so this will only have an obvious effect on stable release. Plus we want this to go into effect soon since the YEC campaign is happening now.

Merging

• Merge to tor-browser - !fixups to tor-browser-specific commits, new features, security backports
• Merge to base-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports
  • NOTE: if your changeset includes patches to both base-browser and tor-browser please clearly label in the change description which commits should be cherry-picked to base-browser after merging

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Review

Request Reviewer

• Request review from an applications developer depending on modified system:
  • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
  • accessibility : henry
  • android : clairehurst, dan
  • build system : boklm
  • extensions : ma1
  • firefox internals (XUL/JS/XPCOM) : ma1
  • fonts : pierov
  • frontend (implementation) : henry
  • frontend (review) : donuts, richard
  • localization : henry, pierov
  • macos : clairehurst, dan
  • nightly builds : boklm
  • rebases/release-prep : dan, ma1, pierov, richard
  • security : ma1
  • signing : boklm, richard
  • updater : pierov
  • misc/other : pierov, richard

Change Description

Before the YEC 2023 banner would be shown on every "about:tor" load, regardless of whether the user closed the banner in a previous load. With this patch the banner will remain hidden for the rest of the session (e.g. for new tabs, new windows and when using new identity).

/cc @donuts

How Tested

Change the code to make isStable always true to see the banner in the dev build.

1. Open tor browser, banner should be shown in "about:tor".
2. Close the banner using the "X" button.
3. Open "about:tor" in a new tab. Banner should be hidden.
4. Open a new window. Banner should be hidden.
5. Trigger "new identity". Banner should be hidden in the new window.
6. Close tor browser and restart. Banner should be visible again.