Bug 42519: Disable portable mode also if is-packaged-app is present.

Merge Info

Related Issues

• #42519 (closed)
• mullvad-browser#xxxxx
• tor-browser-build#xxxxx

Backporting

Timeline

• Immediate: patchset needed as soon as possible
• Next Minor Stable Release: patchset that needs to be verified in nightly before backport
• Eventually: patchset that needs to be verified in alpha before backport
• No Backport (preferred): patchset for the next major stable

(Optional) Justification

• Emergency security update: patchset fixes CVEs, 0-days, etc
• Censorship event: patchset enables censorship circumvention
• Critical bug-fix: patchset fixes a bug in core-functionality
• Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
• Sponsor required: patchset required for sponsor
• Localization: typos and other localization changes that should be also in the release branch
• Other: please explain

Merging

• Merge to tor-browser - !fixups to tor-browser-specific commits, new features, security backports
• Merge to base-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports
  • NOTE: if your changeset includes patches to both base-browser and tor-browser please clearly label in the change description which commits should be cherry-picked to base-browser after merging

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Review

Request Reviewer

• Request review from an applications developer depending on modified system:
  • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
  • accessibility : henry
  • android : clairehurst, dan
  • build system : boklm
  • extensions : ma1
  • firefox internals (XUL/JS/XPCOM) : ma1
  • fonts : pierov
  • frontend (implementation) : henry
  • frontend (review) : donuts, richard
  • localization : henry, pierov
  • macos : clairehurst, dan
  • nightly builds : boklm
  • rebases/release-prep : dan, ma1, pierov, richard
  • security : ma1
  • signing : boklm, richard
  • updater : pierov
  • misc/other : pierov, richard

Change Description

is-packaged-app also disables the portable mode now on Linux, in addition to system-install.

I reimplemented the check rather than using mozilla::widget::IsPackagedAppFileExists because it depends on the directory service. So, I was using that function too early, and the functionality broke as a result.

How Tested

Testbuild available at https://tb-build-03.torproject.org/~pierov/testbuild/tor-browser-linux-x86_64-42519.tar.xz

I started the browser and checked about:profiles:

• checked that by default the browser still had uses the usual paths
• checked with the new is-packaged-app file the profile was inside $HOME (and for us it's in our custom $HOME: strange, but consistent, I guess)
• checked that the behavior of is-packaged-app and system-install is the same (by renaming the file, I haven't checked what happens when both are there)
• deleted the file and checked we went back to the default behavior

/cc @boklm