Skip to content

Bug 40027: Make torbutton_send_ctrl_cmd async

morgan requested to merge morgan/torbutton:40027_rev into master
  • makes torbutton_send_ctrl_cmd async; now implemented using torController.sendCommand rather than handling all of the io, concurrency, and syncrhonization
  • insert asyncs/awaits/catch to the relevant places where torbutton_send_ctrl_cmd are called
  • removed call to torbutton_do_tor_check() from torbutton_new_window()
  • NS_BASE_STREAM_CLOSED returned from read no longer triggers error callback inside io.pumpInputStream
  • tor.controllerCache is now expicitly a JavaScript map object
  • controller() function now has option to always get a new tor.controller, instead of a cached one
  • refactored controller() function to use explicit map() functions

Closes #40027 (closed)

Edited by Matthew Finkel

Merge request reports