Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Arti Arti
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 137
    • Issues 137
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • ArtiArti
  • Merge requests
  • !121

Get rid of tor-proto's ChannelImpl, and use the reactor more instead

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged eta requested to merge eta/arti:bye-channelimpl into main Nov 03, 2021
  • Overview 11
  • Commits 2
  • Pipelines 5
  • Changes 11

Instead of awkwardly sharing the internals of a tor-proto Channel between the reactor task and any other tasks, move most of the internals into the reactor and have other tasks communicate with the reactor via message-passing to allocate circuits and send cells.

This makes a lot of things simple, and has convenient properties like not needing to wrap the Channel in an Arc (though some places in the code still do this for now).

A lot of test code required tweaking in order to deal with the refactor; in fact, fixing the tests probably took longer than writing the mainline code (!). Importantly, we now use tokio's tokio::test annotation instead of async_test, so that we can run things in the background (which is required to have reactors running for the circuit tests).

This is an instance of #205 (closed), and also kind of #217 (closed).

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: bye-channelimpl