Skip to content
Snippets Groups Projects

Accept and transmit padding in introduce2 plaintexts

Merged Accept and transmit padding in introduce2 plaintexts
nickm/arti:pad_intro2 into main
All threads resolved!
Merged Nick Mathewson requested to merge nickm/arti:pad_intro2 into main
All threads resolved!

According to rend-spec, we intentionally accept and discard extra bytes here. Doing so allows us to hide the size of our messages.

Closes #1031 (closed); see discussion there.

I think this code is ready, but I'm marking the MR as Draft until all the discussions on #1031 (closed) and on torspec#222 (closed) are resolved

Merge request reports

Approved by
gabi-250

Merged by Nick MathewsonNick Mathewson 1 year ago (Sep 25, 2023 5:06pm UTC)

Merge details

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • gabi-250
    gabi-250 @gabi-250 ·
    Maintainer

    This looks good to me, just one small question about a debug_assert.

    (not merging as #1031 (closed) and torspec#222 (closed) are not resolved yet)

    Edited by gabi-250
  • gabi-250 approved this merge request

    approved this merge request

  • gabi-250 resolved all threads

    resolved all threads

  • Nick Mathewson marked this merge request as ready

    marked this merge request as ready

  • Nick Mathewson merged

    merged

  • Nick Mathewson mentioned in commit 73cab2d7

    mentioned in commit 73cab2d7

    • Please register or sign in to reply