Skip to content

tor-keymgr: Replace ArtiPathComponent with Slug

gabi-250 requested to merge gabi-250/arti:arti-path-slugs into main

This MR replaces ArtiPathComponent with Slug. As a result, some previously valid ArtiPaths are now rejected (ArtiPaths can no longer contain unicode characters or .), and some previously invalid ArtiPaths are now accepted (now ArtiPath can start with -, _. I'm not sure why this was forbidden in the first place).

HsClientSpecifier and HsNickname are now Slugs internally.

Questions for the reviewer:

  • should we keep ArtiPathComponent (as a newtype for Slug) in case we want to introduce additional restrictions for the slugs that make up ArtiPathComponents?

Closes #1193 (closed), #1092 (closed)

Edited by gabi-250

Merge request reports

Loading