Mark RPC stable, and revise READMEs for RPC crates.

Closes #1883 (closed).

assigned to @nickm

requested review from @Diziet

LGTM.

We don't seem to have a ticket yet for the CI failure which afflicts main. I'll Approve this and I suggest you rebase it when main is fixed...

approved this merge request

PS congratulations!

added 12 commits

• 82cb7e83...b6fee21e - 10 commits from branch tpo/core:main
• bb4c29c9 - Mark rpc features as non-experimental.
• d18e5908 - Revise READMEs for RPC crates.

Compare with previous version

rebased; marking to merge.

enabled an automatic merge when all merge checks for d18e5908 pass

added 5 commits

• d18e5908...8924e996 - 3 commits from branch tpo/core:main
• ec241a08 - Mark rpc features as non-experimental.
• 6232c417 - Revise READMEs for RPC crates.

Compare with previous version

enabled an automatic merge when all merge checks for 6232c417 pass

@jnewsome can you tell what's going on with integration-shadow here? Does it look like I broke something else?

Does it look like I broke something else?

Short answer: no, I don't think so.

From the main job log, the interesting line is:

Error: process 'torclient-onion-artiserver-full-vanguards.tgen.1001' exited with status StoppedByShadow; expected end state was exited: 0 but was running

Looking into the artifacts for the stdout of that process, it looks like this client didn't quite finish the transfers it wanted to do, maybe in part because the first transfer it tried to do ended up stalling out.

This seems unlikely to be linked to a problem with this MR. I think we're cutting the timing a little close here and either the build change "rerolled the dice" for the determinism in the simulation s.t. this is now deterministically not quite finishing in time, or we got unlucky with some lingering source of nondeterminism that shadow hasn't accounted for.

I think we can just bump up the simulation end-time from 30m to something like 35m. This shouldn't appreciably increase the wall-clock time needed to run the simulation. https://gitlab.torproject.org/nickm/arti/-/blob/a10d3e9e1c16f3f9a3174b3bddce7eb1552bb200/tests/shadow/shadow.yaml#L2

LMK if you'd like me to take care of this in a separate MR.

A separate MR would be lovely; thank you!

added 45 commits

• 6232c417...8d32fccc - 43 commits from branch tpo/core:main
• 2e1e19f9 - Mark rpc features as non-experimental.
• 71f0c3ff - Revise READMEs for RPC crates.

Compare with previous version

rebased again, let's see if CI is happy now.

merged

mentioned in commit 1917296f