Skip to content
Snippets Groups Projects

tor_socksproto::Error HasKind fix two delegations

Merged Ian Jackson requested to merge Diziet/arti:errorkind-socksproto-delegate into main

We should not generally explicitly specify a kind for errors which contain a more detailed error which itself has a kind. Stating the kind literally is a latent bug, which becomes a real bug if the contained type's kind changes or starts to vary.

(There may be exceptions to this principle but this isn't one of them.)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading